From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3A06D3BA8E for ; Wed, 29 Nov 2017 07:28:03 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1511958480; bh=bfN2iByKH8KsRyyUBWpLf3O+Nyvdcb6FsuWmzNvW94c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TRVl2/Jx3o0clunq1FJRhBi4PmSA9UgWzb7PmG65WAETBp7r5y+tFeviTGxKtUpE+ TRGowZ3B3tVYZhoj0RKNv+NSjNvoZXp0ONMLmiJ3iz7TFguAj2aOIuuWEnR9iR6VVY I6NMDDxlv5g1FZpFtSoRCQmxsWIhIYmhYKv5dLDzkzKSqFVAhHt8WwQRV1n0g59p8C 3G0vW6+hOsldmW9Os2zmu2H6EI7RTvLZKfPtFZ76NLusgjvCzGQN0n/1rN8UJykVhl noBkNQNdz1qwLukpz15ZE97zZ1norDPpTG/wno9+ftaEwrqAmuN68m/KCI5ZHq8wNG y2OTe41MUUZ/g== To: Dave Taht , Kevin Darbyshire-Bryant Cc: Cake List In-Reply-To: <87k1yaxc65.fsf@nemesis.taht.net> References: <700AAEDF-6D34-4F0B-8B48-E34A554F5B6D@darbyshire-bryant.me.uk> <87a7z6p7cz.fsf@nemesis.taht.net> <0A71A7BA-0FD6-4F1C-97F2-2024626FC561@darbyshire-bryant.me.uk> <87k1yaxc65.fsf@nemesis.taht.net> Date: Wed, 29 Nov 2017 13:27:59 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87shcx6zhs.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] Cake tree unreadable X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 12:28:03 -0000 Dave Taht writes: > A flag day here is feasible. I will fiddle along the lines you > describe. FWIW I don't think the history is that bad. Sure, there are a bunch of merge commits, but picking out the real ones is not that difficult (unless you are using the github web interface, I guess, but that sucks for most things anyway). I'm not sure rewriting history in the existing branch is worth the hassle. We're going to reset history anyway once it's been upstreamed. If you *are* going to rewrite history, please at least do it in a separate branch instead of force pushing to an existing one... > I'm toying with the idea of fixing xstats in a separate branch. I > really hate the idea of breaking backward compatability here, but I do > suspect it will be a barrier to upstreaming, and it is, quite > inefficient. I'm not sure this will actually be enough of a backwards compatibility break to warrant the term 'flag day'. I.e., it won't affect outside behaviour. Sure, you need to update userspace and the kernel module together, but you kinda need to do that anyway when new features are added. And for LEDE, we'll just push updates to both packages at the same time, which should give new images and even `opkg update` a consistent view... So I'd say go ahead and break things. The worst thing that can happen is that some users will lose the statistics until they update their userspace tool... -Toke