Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: John Sager <john@sager.me.uk>, cake@lists.bufferbloat.net
Subject: Re: [Cake] act_connmark + dscp
Date: Thu, 07 Mar 2019 10:50:39 +0100	[thread overview]
Message-ID: <87tvgfypw0.fsf@toke.dk> (raw)
In-Reply-To: <2addb109-0cc4-cdb9-886d-d86da9b5bf51@sager.me.uk>

John Sager <john@sager.me.uk> writes:

> You should be able to infer get (egress action) and set (ingress action)
> from which qdisc it is attached to. Is it possible to do that when the
> action function is invoked (from parameters of tcf_connmark_act() or does it
> need a static flag set when tc attaches the action?

From the TC action point of view there is no difference between what we
call egress and ingress actions. They are just things that happen when
an action is invoked on a qdisc. So we definitely need configuration
flags, and I think it is simpler to just name them 'get' and 'set'
rather than attach any directional meaning to them...

-Toke

  reply	other threads:[~2019-03-07  9:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 14:35 Kevin Darbyshire-Bryant
2019-03-06 15:21 ` Toke Høiland-Jørgensen
2019-03-06 16:47   ` John Sager
2019-03-07  9:50     ` Toke Høiland-Jørgensen [this message]
2019-03-06 18:40   ` Kevin Darbyshire-Bryant
2019-03-07 10:10     ` Toke Høiland-Jørgensen
2019-03-07 15:56       ` Kevin Darbyshire-Bryant
2019-03-07 17:40         ` Toke Høiland-Jørgensen
2019-03-08 11:13           ` Kevin Darbyshire-Bryant
2019-03-08 11:28             ` Toke Høiland-Jørgensen
2019-03-08 14:03               ` Kevin Darbyshire-Bryant
2019-03-09 14:08                 ` Toke Høiland-Jørgensen
2019-03-10 15:21                   ` Kevin Darbyshire-Bryant
2019-03-10 23:56                     ` Toke Høiland-Jørgensen
2019-03-11 10:51                       ` Kevin Darbyshire-Bryant
2019-03-11 13:00                         ` Toke Høiland-Jørgensen
2019-03-11 14:11                           ` Kevin Darbyshire-Bryant
2019-03-11 14:32                             ` Toke Høiland-Jørgensen
2019-03-09 20:21                 ` John Sager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvgfypw0.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=john@sager.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox