From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2F2B53CB35 for ; Thu, 7 Mar 2019 04:50:41 -0500 (EST) Received: by mail-ed1-f51.google.com with SMTP id m35so12870815ede.10 for ; Thu, 07 Mar 2019 01:50:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=EsBDzIIW0HDkIWLfEAiBnpIB5Z90h+cy8YOmjjJmoCo=; b=XxgBY/nM3COVjV8DPtVLCIHkxKI8ltX5AJg1jAUsQPUMHVctYBBDFtocmvckby0NbY eq1I+cmj8B0W0zU2eEHvAzJhjxFAeivyzPmdZllRWZ/kg69q6poem2VuSQ5CYK/6a3Cd QDk4kOT7U89gCRrtRhBrj267CEO2eACFdtwkfDsVXcfwjuLYNLHzWrY+28Ioq8B4jNA+ lnwGipy1e30msLuBWI9SRSKifAUSztZT9BM7yiEEF5vRHOM1hrmkUm0/F+To/LkE5VC4 OGXQ4dvuUQN7vdOaLqobBdzXFACS1gqPslq69jH3vWACAUDIwH1ONDyY5Has8DCIpV5t CUVQ== X-Gm-Message-State: APjAAAXroyxm73qmkAUG2L6rBBDSZSmENcJhBNHHkzFUSxMGDX3VVTV1 n8sHhLb3VdbQ2nJOgeSk9fg0Tu5w1Fk= X-Google-Smtp-Source: APXvYqwoHCqF/fRHVmvp7P/m5vsG2WiKlT7ABs5SEFH9yTjjN3WjomrkRYgCM2O4F1bGj8ADDdA7hg== X-Received: by 2002:a05:6402:13cd:: with SMTP id a13mr28143911edx.152.1551952240145; Thu, 07 Mar 2019 01:50:40 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id gq12sm787445ejb.21.2019.03.07.01.50.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 01:50:39 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 40EAD182F5B; Thu, 7 Mar 2019 10:50:39 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: John Sager , cake@lists.bufferbloat.net In-Reply-To: <2addb109-0cc4-cdb9-886d-d86da9b5bf51@sager.me.uk> References: <875zsw110r.fsf@toke.dk> <2addb109-0cc4-cdb9-886d-d86da9b5bf51@sager.me.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 07 Mar 2019 10:50:39 +0100 Message-ID: <87tvgfypw0.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] act_connmark + dscp X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 09:50:41 -0000 John Sager writes: > You should be able to infer get (egress action) and set (ingress action) > from which qdisc it is attached to. Is it possible to do that when the > action function is invoked (from parameters of tcf_connmark_act() or does it > need a static flag set when tc attaches the action? >From the TC action point of view there is no difference between what we call egress and ingress actions. They are just things that happen when an action is invoked on a qdisc. So we definitely need configuration flags, and I think it is simpler to just name them 'get' and 'set' rather than attach any directional meaning to them... -Toke