From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: George Amanakis <gamanakis@gmail.com>, chromatix99@gmail.com
Cc: cake@lists.bufferbloat.net, George Amanakis <gamanakis@gmail.com>,
Pete Heist <peteheist@gmail.com>
Subject: Re: [Cake] Make the dual modes fairer
Date: Thu, 14 Feb 2019 22:59:03 +0100 [thread overview]
Message-ID: <87tvh6rpzs.fsf@toke.dk> (raw)
In-Reply-To: <20190214212231.12308-1-gamanakis@gmail.com>
George Amanakis <gamanakis@gmail.com> writes:
> Host fairness does not work well with TCP flows in dual-srchost and
> dual-dsthost setup. The reason is that ACKs generated by TCP flows
> are classified as sparse flows, and affect flow isolation from other
> hosts. Fix this by calculating host_load based only on the bulk flows
> a host generates. In a hash collision the host_bulk_flow_count values must
> be decremented on the old hosts and incremented on the new ones *if* the
> queue is in the bulk set.
Right, thanks! Pushed this to master; go forth and test, everyone! :)
-Toke
next prev parent reply other threads:[~2019-02-14 21:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 17:33 [Cake] progress? dual-src/dsthost unfairness Kevin Darbyshire-Bryant
2019-02-13 18:31 ` George Amanakis
2019-02-13 18:41 ` Jonathan Morton
2019-02-13 19:26 ` gamanakis
2019-02-13 19:31 ` Jonathan Morton
2019-02-13 19:35 ` gamanakis
2019-02-13 20:55 ` George Amanakis
2019-02-14 11:15 ` Toke Høiland-Jørgensen
2019-02-14 18:02 ` George Amanakis
2019-02-14 18:14 ` Toke Høiland-Jørgensen
2019-02-14 18:45 ` [Cake] Make the dual modes fairer George Amanakis
2019-02-14 19:07 ` [Cake] progress? dual-src/dsthost unfairness Jonathan Morton
2019-02-14 20:27 ` gamanakis
2019-02-14 21:22 ` [Cake] Make the dual modes fairer George Amanakis
2019-02-14 21:59 ` Toke Høiland-Jørgensen [this message]
2019-02-14 19:00 ` [Cake] progress? dual-src/dsthost unfairness Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvh6rpzs.fsf@toke.dk \
--to=toke@redhat.com \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=gamanakis@gmail.com \
--cc=peteheist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox