From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4CFDD3CB35 for ; Thu, 14 Feb 2019 16:59:05 -0500 (EST) Received: by mail-ed1-f53.google.com with SMTP id d9so6312073edh.12 for ; Thu, 14 Feb 2019 13:59:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=B0HsJnpqypi5XpwTrtCy/mU0JBDiWwEjDT+l98yOD5Q=; b=l/BegJ6rg1Ol7+kFmPXx/eCSaRikuI8ukWLpPIDeoIpbu+ECGMvu52EfieEWJAUpyL sAY3lVhEPLhJqWd868JxqeWaXjoG91szDKgELte4cxzL6J9FhUwkM6kc23V2ANPI82OH 5ugdXaF7y8Eo1h/HLEXjrJFbkt4ftF3k8VkurqtIxfJM+54ROxbERn0ShHjn8hzslfkN 49Pfcv1+3/3RS9wRnw9C8TdfdXFII2b3/davZGSqJ/r+j3HhGzsuZ88RkrRc/ywDj3Uh 0S66whTVloCkwCLXUN+Hjp0pbUSoezG43qBWVjwHpuLYcPA/qgl9LVXApKEyVH53QYj0 QEmg== X-Gm-Message-State: AHQUAubgM31fA3VXxxxREXjvB7PmyqvjVCfNB/XgHSRpd1sYXWbICgEp IGucNmBZBbokcMKdN8Tflgdv7g== X-Google-Smtp-Source: AHgI3IaYRReEw7COFEs2GxaL+y9Vx8ktioSQEryYbiLevceK+nSAtBO4Pe3HtLXYQiBr8qcbiDXJqA== X-Received: by 2002:a50:98a6:: with SMTP id j35mr4818768edb.141.1550181544404; Thu, 14 Feb 2019 13:59:04 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id k20sm801691eja.33.2019.02.14.13.59.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 13:59:03 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3BA5B1825DD; Thu, 14 Feb 2019 22:59:03 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: George Amanakis , chromatix99@gmail.com Cc: cake@lists.bufferbloat.net, George Amanakis , Pete Heist In-Reply-To: <20190214212231.12308-1-gamanakis@gmail.com> References: <003401d4c4a3$b8502340$28f069c0$@gmail.com> <20190214212231.12308-1-gamanakis@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 14 Feb 2019 22:59:03 +0100 Message-ID: <87tvh6rpzs.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] Make the dual modes fairer X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 21:59:05 -0000 George Amanakis writes: > Host fairness does not work well with TCP flows in dual-srchost and > dual-dsthost setup. The reason is that ACKs generated by TCP flows > are classified as sparse flows, and affect flow isolation from other > hosts. Fix this by calculating host_load based only on the bulk flows > a host generates. In a hash collision the host_bulk_flow_count values must > be decremented on the old hosts and incremented on the new ones *if* the > queue is in the bulk set. Right, thanks! Pushed this to master; go forth and test, everyone! :) -Toke