From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Pete Heist <pete@heistp.net>, Jonathan Morton <chromatix99@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] issue with Cake and bpf filter
Date: Wed, 22 Aug 2018 11:37:09 +0200 [thread overview]
Message-ID: <87tvnm91yy.fsf@toke.dk> (raw)
In-Reply-To: <03B32CF6-2926-42A7-A407-CBD16BA38F0D@heistp.net>
Pete Heist <pete@heistp.net> writes:
>> On Aug 22, 2018, at 8:17 AM, Jonathan Morton <chromatix99@gmail.com> wrote:
>>
>>> On 22 Aug, 2018, at 12:06 am, Pete Heist <pete@heistp.net> wrote:
>>>
>>> when fq_codel is the qdisc, the eBPF action is only called "once in a while”
>>
>> One difference between fq_codel and Cake is that the former - which
>> has no shaper - will "bypass" packets when it's empty and there's no
>> back-pressure filling it. In that case no packet classification
>> occurs and filters will not be called. Or at least, that's how it
>> used to be set up; I haven't looked at it recently. Cake does not
>> rely on the same set of assumptions, so will always call the filter.
>
> Aha, that sounds likely, I’ll try with htb and a rate limit. Testing
> with fq_codel was challenging as I had to “do stuff” until my printk’s
> were eventually called, but it’s easier now that I can use cake. I
> suppose in my case fq_codel’s behavior would be ok in production,
> because if there’s no queue then there’s no need to classify. Maybe in
> some other cases (like gathering stats), it could be problematic.
fq_codel turns off the bypass capability if you attach a tc filter to
it, though, so if the issue you're seeing is that you filter function is
not being called, that sounds... strange...
How do you check if the function is being called?
-Toke
next prev parent reply other threads:[~2018-08-22 9:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 8:17 Pete Heist
2018-08-12 10:23 ` Pete Heist
2018-08-12 13:41 ` Jonathan Morton
2018-08-12 19:42 ` Toke Høiland-Jørgensen
2018-08-12 21:34 ` Jonathan Morton
2018-08-13 0:21 ` Jonathan Morton
2018-08-13 5:44 ` Jonathan Morton
2018-08-13 11:01 ` Toke Høiland-Jørgensen
2018-08-21 11:25 ` Toke Høiland-Jørgensen
2018-08-21 21:06 ` Pete Heist
2018-08-21 21:17 ` Toke Høiland-Jørgensen
2018-08-21 21:46 ` Pete Heist
2018-08-22 9:49 ` Toke Høiland-Jørgensen
2018-08-22 9:41 ` Toke Høiland-Jørgensen
2018-08-22 6:17 ` Jonathan Morton
2018-08-22 9:30 ` Pete Heist
2018-08-22 9:37 ` Toke Høiland-Jørgensen [this message]
2018-08-22 9:51 ` Pete Heist
2018-08-22 10:00 ` Jonathan Morton
2018-08-22 10:13 ` Toke Høiland-Jørgensen
2018-08-22 10:32 ` Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvnm91yy.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox