Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave@taht.net>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] [RFC PATCH 2/3] Add cake related includes and source files
Date: Tue, 21 Nov 2017 11:03:38 -0800	[thread overview]
Message-ID: <87tvxntpx1.fsf@nemesis.taht.net> (raw)
In-Reply-To: <dbf49d41-27e1-5d4c-ad23-093d3d2d442e@gmail.com> (Jonathan Morton's message of "Tue, 21 Nov 2017 00:08:18 +0200")

Jonathan Morton <chromatix99@gmail.com> writes:

> On 17/11/17 21:52, Dave Taht wrote:
>>> +#define REC_INV_SQRT_CACHE (16)
>
>> Never been proven that this cache either improves cpu utiliziation, nor
>> that the added accuracy has any effect. I'd like to be able to
>> completely compile out the cache.
>
> CPU utilisation is debatable.  It could go either way, actually, compared to a
> *single* unconditional Newton step.  The cache is probably faster than
> *multiple* Newton steps which would be required to guarantee the same accuracy.
>
> However, a few minutes' work with a spreadsheet is sufficient to show a *big*
> difference in timing between the accurate values placed in the cache and the
> approximations given by a single Newton step for small count values,
> particularly when stepping from count 1 to 2 or vice versa.  Above 16, a single
> Newton step gives sufficient accuracy in either direction, given the precision
> stored.

> The magnitude of the error when stepping up to count 2 is such as to give the
> value that *should* have been produced at count 4.

I am going to add this as a comment.

> Since you are presently
> concerned elsewhere with Cobalt's supposedly "aggressive" behaviour, removing
> the cache would definitely make that worse.

I would like to work towards a stable version that can be benchmarked at
long rtts. The network namespace stuff is helping here to simulate that.

  parent reply	other threads:[~2017-11-21 19:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 19:11 [Cake] [RFC PATCH 0/3] Cake patches for net-next Dave Taht
2017-11-17 19:11 ` [Cake] [RFC PATCH 1/3] Add cake to pkt_sched.h Dave Taht
2017-11-17 19:11 ` [Cake] [RFC PATCH 2/3] Add cake related includes and source files Dave Taht
2017-11-17 19:52   ` Dave Taht
     [not found]     ` <91830311-fea3-cb03-be2e-b132ae54ad89@gmail.com>
2017-11-21 18:59       ` Dave Taht
     [not found]     ` <dbf49d41-27e1-5d4c-ad23-093d3d2d442e@gmail.com>
2017-11-21 19:03       ` Dave Taht [this message]
     [not found]     ` <f7a57f62-9b61-5e4f-6734-dc92f2758d2f@gmail.com>
2017-11-21 19:04       ` Dave Taht
     [not found]     ` <fe13b27c-223f-f9d2-b153-44fbe388ff50@gmail.com>
2017-11-21 19:05       ` Dave Taht
     [not found]     ` <5fbd8b62-f557-d9f6-0396-8bd9135b7c74@gmail.com>
2017-11-21 19:07       ` Dave Taht
2017-11-17 19:11 ` [Cake] [RFC PATCH 3/3] Add support for building the new cake qdisc Dave Taht
2017-11-17 19:21   ` Toke Høiland-Jørgensen
2017-11-17 19:55     ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvxntpx1.fsf@nemesis.taht.net \
    --to=dave@taht.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox