Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: cake@lists.bufferbloat.net
Subject: [Cake] CAKE upstreaming - testers wanted, ACK filtering rescuers needed
Date: Wed, 25 Apr 2018 22:45:56 +0200	[thread overview]
Message-ID: <87vacf3th7.fsf@toke.dk> (raw)

For those who have not been following the discussion on the upstreaming
patches, here's an update:

- I've just pushed patches to only split GSO packets when shaping below
  one gigabit; and hopefully made the overhead compensation code deal
  gracefully with GSO packets if someone for some reason wants to use
  the shaper at speeds higher than that and still use the overhead
  compensation code.

- It turns out that the ACK filtering code does not properly sanity
  check the packet sizes, and so can potentially crash the box running
  CAKE if it receives malformed packets. So if no one steps up to fix
  that within the next few days, or I'll submit the next version without
  it (I'm not going to open that particular can of worms)... This
  doesn't mean it can't be added back later, of course, it just means it
  won't go upstream this time around.

- NAT mode is now enabled by default; doesn't seem to be a good reason
  not to as the compile time dependency already makes the module depend
  on conntrack.


So please do test the current git version (cobalt branch, still). I'm
planning to resubmit on Friday.

-Toke

             reply	other threads:[~2018-04-25 20:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 20:45 Toke Høiland-Jørgensen [this message]
2018-04-26  1:10 ` Ryan Mounce
2018-04-26  1:32   ` Stephen Hemminger
2018-04-26  3:23     ` Dave Taht
2018-04-26  6:39   ` Toke Høiland-Jørgensen
2018-04-26  6:54     ` Ryan Mounce
2018-04-26  7:14       ` Toke Høiland-Jørgensen
2018-04-26  7:19 ` Kevin Darbyshire-Bryant
2018-04-26  7:34   ` Toke Høiland-Jørgensen
2018-04-26  8:43     ` Jonas Mårtensson
2018-04-26  8:55       ` Toke Høiland-Jørgensen
2018-04-26 12:02         ` Jonas Mårtensson
     [not found] ` <mailman.301.1524727201.3573.cake@lists.bufferbloat.net>
2018-04-26  7:26   ` Jonathan Morton
2018-04-26  7:43     ` Sebastian Moeller
2018-04-26 14:42       ` Jonathan Morton
2018-04-26 15:25         ` Sebastian Moeller
2018-04-27  0:17       ` David Lang
2018-04-26  8:16     ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vacf3th7.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox