From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 066D53BA8E
 for <cake@lists.bufferbloat.net>; Wed, 25 Apr 2018 16:45:58 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1524689157; bh=Se2IYFbz5ObFCqnSpcXR4lQNiTzQp06lV4baYs3I/EE=;
 h=From:To:Subject:Date:From;
 b=w96BIWg6ewFWkWMZBMc2wR1xrhYTcXYh5vMficS/2sQyOJjIJAjcjvxOAQwIuO39s
 45BU03mzd662lcmx3/eBHa6y4bstWNp8/0Om41C4mFokIzgCEmfQCfpcjS+hYHf2zJ
 6PlMxpsVxl2EkyK+WikTPOUYMrtVx2fxWlQJDhPepCBFMIdM+60fpvAEhq6AJh8ArT
 GuiiDgc7hswEwaezRuiB2ZBhmg1FTG5uisszfFFQs4RpjHHbRWUIwCMhn3Zb8zzHCj
 aJqFrj3DbDWQdr5GGGB9rAwzOv4HIaXTffCP61GyMbcKbL3mFBwMeW0Qj8nsgB/Rup
 IYkPK78AJ9Kbg==
To: cake@lists.bufferbloat.net
Date: Wed, 25 Apr 2018 22:45:56 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87vacf3th7.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Subject: [Cake] CAKE upstreaming - testers wanted,
	ACK filtering rescuers needed
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 20:45:59 -0000

For those who have not been following the discussion on the upstreaming
patches, here's an update:

- I've just pushed patches to only split GSO packets when shaping below
  one gigabit; and hopefully made the overhead compensation code deal
  gracefully with GSO packets if someone for some reason wants to use
  the shaper at speeds higher than that and still use the overhead
  compensation code.

- It turns out that the ACK filtering code does not properly sanity
  check the packet sizes, and so can potentially crash the box running
  CAKE if it receives malformed packets. So if no one steps up to fix
  that within the next few days, or I'll submit the next version without
  it (I'm not going to open that particular can of worms)... This
  doesn't mean it can't be added back later, of course, it just means it
  won't go upstream this time around.

- NAT mode is now enabled by default; doesn't seem to be a good reason
  not to as the compile time dependency already makes the module depend
  on conntrack.


So please do test the current git version (cobalt branch, still). I'm
planning to resubmit on Friday.

-Toke