Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Georgios Amanakis <gamanakis@gmail.com>,
	Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] profiling using perf
Date: Sat, 09 Mar 2019 17:03:11 +0100	[thread overview]
Message-ID: <87wol83uio.fsf@toke.dk> (raw)
In-Reply-To: <CACvFP_hF5BMTrVFNxLZqeVmyLUHbFcDvMxbxmKfO=_T6zqF+GQ@mail.gmail.com>

Georgios Amanakis <gamanakis@gmail.com> writes:

> Dear List,
>
> I made an effort to profile the performance of cake with perf in
> openwrt. perf was run on a WRT1900ACS router while downloading
> archlinux.iso via torrent in a LAN client. You can find the annotated
> sch_cake.c in the attachment as well as a performance histogram of
> sch_cake (percentages are relative to sch_cake). Hopefully people can
> take a look at it, and see if there are performance concerns.

Hmm, nothing immediately jumps out as low-hanging fruit to be harvested.
It's not too surprising the 200+-line cake_dequeue() is where most time
is spent, since that is where the bulk of the algorithm is implemented.

And, well, there's nothing in there that can obviously be removed unless
we want to drop features. I guess one could try to make it possible to
disable features at compile time; but that carries quite a bit of
complexity with it (for one, it needs testing with the combinatorial
explosion of possible configurations), so don't think it's realistic.
The only exception *might* be a compile time option to turn off those
stats that are not needed for the algorithm to run...

-Toke

  reply	other threads:[~2019-03-09 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 20:58 Georgios Amanakis
2019-03-08 21:01 ` Georgios Amanakis
2019-03-09 16:03   ` Toke Høiland-Jørgensen [this message]
2019-03-11 14:49     ` Adrian Popescu
2019-03-11 15:53       ` Jonathan Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wol83uio.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=gamanakis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox