From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 497A23BA8E for ; Sat, 28 Apr 2018 17:49:25 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1524952163; bh=DDsaPT24fiDkVvjjnag3717RjVjKWwnQdGcrLcWEZ0U=; h=From:To:Subject:Date:From; b=OH4wrBPgowb3U9u1VO3+Cfxy6n18Oet6yBYOs6WpMi7PJ++SUZL3nSJXSROGH/4Vq XNpdMxer/eBrrR1y8h8xBHjPAEmJk9qZ9jYJSGzTb/l+CDlvqF+cwumKxBGhbeYUvq +kq86S43AIisETsse7sTt/Xjo9wFh6+j3LSlPtnB/IQ8lR9cmy62HISY2gQL8ZS1pE W5doL2iAazeV+cvP/x6KGifoq6uoIYVAzJQc1CqQ/LyXNhSWd9melGJwzAs9oENRpj 2xas3sqLde9nGOK/T3+Mltm7Ma3Ivh+uQ6sHr6S5W2pNCQkH/736O3ovIMZArdWt1/ iZRW5kyMakSxw== To: cake@lists.bufferbloat.net Date: Sat, 28 Apr 2018 23:49:22 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87wowr2e8t.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: [Cake] Hopefully fixed ACK filter for v6 X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Apr 2018 21:49:25 -0000 Think I finally managed to fix the ACK filter so it works for both 6in4 and regular v6 (the latter seems to have been broken since the commit "e6b72c2 ack_filter: make less aggressive by default" which accidentally reversed the address compare logic). It should also be safe against weirdly fragmented packets (ha! famous last words!). If someone wants to either eyeball the code and/or test the ACK filter please do. I'm planning to resubmit the patch to netdev sometime tomorrow evening :) -Toke