From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Pete Heist <pete@heistp.net>, cake@lists.bufferbloat.net
Subject: Re: [Cake] lockup with cake and veth
Date: Fri, 06 Jul 2018 15:29:28 +0200 [thread overview]
Message-ID: <87y3eoa3wn.fsf@toke.dk> (raw)
In-Reply-To: <761C7004-247B-42B4-B56C-2527816826C7@heistp.net>
Pete Heist <pete@heistp.net> writes:
> I don’t know if we want to call this an issue, but...
>
> I’m seeing a lockup with cake (and also sfq, but not either pfifo or
> fq_codel), when run over veth devices. Two network namespaces are
> created, one for client and one for server, each with one veth device.
> Netem is added as the root qdisc with a delay of 1ms, and a leaf qdisc
> may be added. Lockups occur on my box when the leaf qdisc is either
> cake or sfq, and I'm running flent’s tcp_ndown test with >= 4 download
> streams. Note that I happen to be running on a quad-core.
>
> - If no leaf qdisc is added below netem, no lockup occurs.
> - If either pfifo or fq_codel is added below netem, no lockup occurs.
> - If either cake or sfq is the leaf, the lockup occurs.
>
> The symptoms (lockup with >= 4 streams on a quad-core box), and the
> fact that it occurs with both cake and sfq, make me think that it may
> simply have to do with the code not being re-entrant, which may be the
> case for veth, and this is just by design? maybe something that we
> should consider fixing but wouldn’t be a show-stopper? But that should
> be confirmed.
>
> I’ll keep investigating, but am sharing the scripts I’m running
> meanwhile in case anyone else wants to look. See README.txt in the
> attached...
Thanks for investigating! I'll take a look later. The fact that it
happens with sfq as well means it's probably not cake-specific, though,
so I don't think we should hold off on the upstream submission until
we've figured it out. Using leaf qdiscs with netem has been dodgy for a
while IIRC...
-Toke
next prev parent reply other threads:[~2018-07-06 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:17 Pete Heist
2018-07-06 13:29 ` Toke Høiland-Jørgensen [this message]
2018-07-06 13:34 ` Georgios Amanakis
2018-07-06 13:37 ` Pete Heist
2018-07-06 19:24 ` Pete Heist
2018-07-06 19:40 ` Dave Taht
2018-07-06 22:12 ` Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3eoa3wn.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox