From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Dave Taht <dave.taht@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc
Date: Tue, 01 May 2018 23:54:01 +0200 [thread overview]
Message-ID: <87y3h311qe.fsf@toke.dk> (raw)
In-Reply-To: <c43e3156-dce2-ced7-3a8f-47fe756202f9@gmail.com>
Eric Dumazet <eric.dumazet@gmail.com> writes:
> On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote:
>
>> Could you comment on specifically what you believe is broken in this,
>> please, so I can fix it in the same iteration?
>>
>
> Apart from the various pskb_may_pull() this helper should not change skb layout.
>
> Ideally, the skb should be const and you would use
> skb_header_pointer() to make clear you do not ever write this skb.
>
> This would make the reviewer job pretty easy, as no side effect can
> possibly happen.
Gotcha. Will fix; thanks :)
-Toke
next prev parent reply other threads:[~2018-05-01 21:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 21:34 Toke Høiland-Jørgensen
2018-04-30 21:21 ` Cong Wang
2018-04-30 21:27 ` Dave Taht
2018-04-30 23:04 ` Cong Wang
2018-05-01 11:36 ` Toke Høiland-Jørgensen
2018-05-01 16:06 ` Eric Dumazet
2018-05-01 18:31 ` Jonathan Morton
2018-05-01 18:53 ` Toke Høiland-Jørgensen
2018-05-01 19:12 ` Eric Dumazet
2018-05-01 19:14 ` David Miller
2018-05-01 19:31 ` Toke Høiland-Jørgensen
2018-05-01 19:41 ` Eric Dumazet
2018-05-01 21:54 ` Toke Høiland-Jørgensen [this message]
2018-05-01 22:31 ` Cong Wang
2018-05-01 19:22 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3h311qe.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox