From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 7F5323BA8E
 for <cake@lists.bufferbloat.net>; Tue,  1 May 2018 17:54:01 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1525211640; bh=1U4dsnbueRdc5HwbM/EvHZrOZ+nlDLgSQ2KJU7G85wc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=qkC8Kdl4jVsT8UyKHK8h6nCzxwB26ZpXiVv64AR+F7HO/ssHgdtPXFifPXATKI62e
 CjJbm/RotsDt6nNWM0rMMt5ErS1jgd7kIyZhX/gw+ePudr49WkZbJNXfzAxVqX334K
 WdVE5vdoQpk1PniOOBCAm0UIqTkrJwhznS9E+Lnh1/8kmYAsvakJwjVfiOYbXnQ+8t
 +/81VUsNnULNRdDdTnUVyXAz+V+D+e4CUW1I2f/nQfRbgVUme83s8q3UhnaA6+Cyar
 SFqpQyN4NLJaNZKvDSPrgBksW6heOR2rv0ktD5KbwIYyQMV71X6G6KVNpEMQp4vjea
 P08wBmlFbwWvg==
To: Eric Dumazet <eric.dumazet@gmail.com>,
 Eric Dumazet <eric.dumazet@gmail.com>, Dave Taht <dave.taht@gmail.com>,
 Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>
In-Reply-To: <c43e3156-dce2-ced7-3a8f-47fe756202f9@gmail.com>
References: <20180429213439.7389-1-toke@toke.dk>
 <CAM_iQpWVrhoo+PjguBLYqwyGyX98Cv3-M=G+CbHrwBom13fwZQ@mail.gmail.com>
 <CAA93jw6F+c-QRXe+MA2QmRkwiKEBqFgOFKTvWGfO7FvCQ5tFvw@mail.gmail.com>
 <dff5ba09-1b81-7cd8-4be3-e7a419797d8e@gmail.com> <878t932ont.fsf@toke.dk>
 <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com> <871sev2mvx.fsf@toke.dk>
 <c43e3156-dce2-ced7-3a8f-47fe756202f9@gmail.com>
Date: Tue, 01 May 2018 23:54:01 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87y3h311qe.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v6] Add Common Applications Kept
	Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 01 May 2018 21:54:01 -0000

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On 05/01/2018 12:31 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>
>> Could you comment on specifically what you believe is broken in this,
>> please, so I can fix it in the same iteration?
>>=20
>
> Apart from the various pskb_may_pull() this helper should not change skb =
layout.
>
> Ideally, the skb should be const and you would use
> skb_header_pointer() to make clear you do not ever write this skb.
>
> This would make the reviewer job pretty easy, as no side effect can
> possibly happen.

Gotcha. Will fix; thanks :)

-Toke