Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Pete Heist <peteheist@gmail.com>
Cc: make-wifi-fast@lists.bufferbloat.net,  cake@lists.bufferbloat.net
Subject: Re: [Cake] [Make-wifi-fast] Flent results for point-to-point Wi-Fi on LEDE/OM2P-HS available
Date: Thu, 09 Feb 2017 14:51:52 +0100	[thread overview]
Message-ID: <87y3xfsc93.fsf@toke.dk> (raw)
In-Reply-To: <B634E201-E73D-49DC-AAA8-D6F6C1FBCF8E@gmail.com> (Pete Heist's message of "Thu, 9 Feb 2017 08:45:05 +0100")

Pete Heist <peteheist@gmail.com> writes:

>> On Feb 8, 2017, at 5:11 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>> 
>>> That reminds me, is there any way to disable fq-codel in the ath9k
>>> driver, and revert to being able to use the qdisc layer without
>>> limiting? Then I could do this testing without having to install Chaos
>>> Calmer, and it could avoid some re-flashing in case I need to re-test
>>> something in the new driver code again.
>> 
>> Nope, no way to turn it off.
>
> Ok, it would be convenient for testing.

Yeah, but "it should be easy to test how crappy the old code was" is not
a very good argument for putting code into the kernel ;)

What you can do is have two different versions of mac80211.ko and
ath9k.ko and reload them between your test runs. There's even code in
Flent to capture the module version which you can use to distinguish
between the cases.

> Also, could the queue management code be abstracted into a separate
> module, so it can be replaced, like a qdisc? I don’t know if the
> disparity between hardware makes this too difficult or not…

Well it's abstracted into mac80211 so all wireless drivers can use it
(theoretically; right now only ath9k, ath10k and the not-yet-merged mt76
do). Making it more generic than that is not possible, since it's tied
to the mac80211 data structures. Which is kinda the point; the whole
problem was that a "generic layer" (the qdisc) didn't work well
enough...

-Toke

  reply	other threads:[~2017-02-09 13:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 21:21 [Cake] " Pete Heist
2017-01-30 21:44 ` [Cake] [Make-wifi-fast] " Toke Høiland-Jørgensen
2017-01-30 22:48   ` Aaron Wood
2017-02-01 14:53     ` Toke Høiland-Jørgensen
2017-01-30 23:21   ` Dave Taht
2017-01-31 16:40     ` Pete Heist
2017-02-14  8:56     ` Pete Heist
2017-02-15 23:03       ` Dave Täht
2017-02-16  7:57         ` Pete Heist
2017-02-16  8:42           ` Sebastian Moeller
2017-02-16  9:17             ` Pete Heist
2017-02-16 16:15               ` Aaron Wood
2017-02-16 16:21                 ` Sebastian Moeller
2017-02-16 16:51                   ` Pete Heist
2017-02-16 17:19                     ` Jonathan Morton
2017-02-16 19:05                       ` Pete Heist
2017-02-16 20:54                         ` Pete Heist
2017-02-16 21:03                       ` Sebastian Moeller
2017-02-17  7:53                         ` Pete Heist
2017-02-17  9:52                           ` Toke Høiland-Jørgensen
2017-02-19 15:25       ` Dave Taht
2017-01-31 15:52   ` Pete Heist
2017-02-01 14:48     ` Toke Høiland-Jørgensen
2017-02-02  8:25       ` Pete Heist
2017-02-07 11:57         ` Toke Høiland-Jørgensen
2017-02-08 15:26           ` Pete Heist
2017-02-08 16:11             ` Toke Høiland-Jørgensen
2017-02-08 16:35               ` Dave Taht
2017-02-08 17:10                 ` Dave Taht
2017-02-08 17:11                   ` Dave Taht
2017-02-09  8:35                 ` Pete Heist
2017-02-09  7:45               ` Pete Heist
2017-02-09 13:51                 ` Toke Høiland-Jørgensen [this message]
2017-02-09 14:20                   ` Pete Heist
2017-02-09 14:44                     ` Toke Høiland-Jørgensen
2017-02-10  7:51                       ` Pete Heist
2017-02-08 18:29             ` John Yates
2017-01-30 23:55 ` Dave Taht
2017-01-31 16:58   ` Pete Heist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3xfsc93.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=make-wifi-fast@lists.bufferbloat.net \
    --cc=peteheist@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox