From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E4A753B2A4; Thu, 9 Feb 2017 08:51:58 -0500 (EST) Received: from mail.toke.dk (localhost.localdomain [127.0.0.1]) by mail.toke.dk (Postfix) with ESMTPS id 52C3B6A96F; Thu, 9 Feb 2017 14:51:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1486648317; bh=f5ZykN8k5oHKz1n0cWhqPBiWA2AKwzd0GpSikbIs0NA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YwIkSXvt2kMQiUXf4vN791MoJZIWvGd/3rVUS03jukAIFD9M/pPegh32GYmeQy9iT X/9uftU/lKow/rTjdB7N6wZSw+hY6HzXLmrf5vZlG4nRcmGVkRjAxVar1ZiWUot268 CAXqxhfFWvv4h7Ea2bAgGDAsPWkaEZ2O0wVWPsErDtfg+pedkgpZ2WBUw/+pxtmHiL g3Hu+q4XGi1ukCLvTsYTnCT5/O6xuRvWQwy1z3ipY4rE1St2eFW1OuroEvdY4iPbya rPb1lCZnQBi3u5JmfHMpJ2tt5zT6QJVnN7xEgNUxPFsfMn3dBkPAJXQOIjRAqA9fC0 kybYT/KZx5nAA== Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8968E193CD; Thu, 9 Feb 2017 14:51:52 +0100 (CET) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Pete Heist Cc: make-wifi-fast@lists.bufferbloat.net, cake@lists.bufferbloat.net References: <32C42951-373F-4D90-8936-AA07039E5D73@gmail.com> <877f5c2pew.fsf@toke.dk> <878tpqge5g.fsf@toke.dk> <877f52rz68.fsf@toke.dk> <87bmucu0gs.fsf@toke.dk> Date: Thu, 09 Feb 2017 14:51:52 +0100 In-Reply-To: (Pete Heist's message of "Thu, 9 Feb 2017 08:45:05 +0100") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87y3xfsc93.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [Make-wifi-fast] Flent results for point-to-point Wi-Fi on LEDE/OM2P-HS available X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 13:52:04 -0000 Pete Heist writes: >> On Feb 8, 2017, at 5:11 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>=20 >>> That reminds me, is there any way to disable fq-codel in the ath9k >>> driver, and revert to being able to use the qdisc layer without >>> limiting? Then I could do this testing without having to install Chaos >>> Calmer, and it could avoid some re-flashing in case I need to re-test >>> something in the new driver code again. >>=20 >> Nope, no way to turn it off. > > Ok, it would be convenient for testing. Yeah, but "it should be easy to test how crappy the old code was" is not a very good argument for putting code into the kernel ;) What you can do is have two different versions of mac80211.ko and ath9k.ko and reload them between your test runs. There's even code in Flent to capture the module version which you can use to distinguish between the cases. > Also, could the queue management code be abstracted into a separate > module, so it can be replaced, like a qdisc? I don=E2=80=99t know if the > disparity between hardware makes this too difficult or not=E2=80=A6 Well it's abstracted into mac80211 so all wireless drivers can use it (theoretically; right now only ath9k, ath10k and the not-yet-merged mt76 do). Making it more generic than that is not possible, since it's tied to the mac80211 data structures. Which is kinda the point; the whole problem was that a "generic layer" (the qdisc) didn't work well enough... -Toke