From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by huchra.bufferbloat.net (Postfix) with ESMTPS id F01FE21F716
	for <cake@lists.bufferbloat.net>; Wed,  4 Nov 2015 10:51:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at mail2.tohojo.dk
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310;
	t=1446663068; bh=Pv/HXA+b2lz4W2a91Z/L7O+ylSWITv5lvVzj9KqfxMQ=;
	h=From:To:Cc:Subject:References:Date:In-Reply-To;
	b=GMT4NOjThHtPeK9nHdlVKtgnh4VgOJzL4wN88tlZYGYozE7dogZ5APUAwHP44r9ow
	Y8aVHCLm9M7eD4AuHfJZttJGEP3z4qvbJyC0YQ+/Y6o+fL0Jor9FSS+10axz+xkiso
	eUHQg5E6Nx+5fhvU2D+uwrMOzC7BxYQtF1JAfh60=
Sender: toke@toke.dk
Received: by alrua-karlstad.karlstad.toke.dk (Postfix, from userid 1000)
	id 33A3A4EBCE5; Wed,  4 Nov 2015 19:51:07 +0100 (CET)
From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
References: <87oafbnsqn.fsf@toke.dk>
	<5638B29D.9020503@darbyshire-bryant.me.uk> <87k2pzns29.fsf@toke.dk>
	<6F28B0F0-8333-4753-802E-BDDAC42CBC7B@gmail.com>
	<87oafbat54.fsf@toke.dk>
	<D80A799A-73D0-4BD5-8A75-8ACE287A3CC1@gmail.com>
	<877flzas49.fsf@toke.dk> <87pozqaomi.fsf@toke.dk>
	<CAA93jw5onb24eij42iYBfHGWAfuFdCK0fnBnnk6TKuoGWKEPXw@mail.gmail.com>
	<8737wm9g1y.fsf@toke.dk> <563A48AA.1080405@darbyshire-bryant.me.uk>
Date: Wed, 04 Nov 2015 19:51:07 +0100
In-Reply-To: <563A48AA.1080405@darbyshire-bryant.me.uk> (Kevin
	Darbyshire-Bryant's message of "Wed, 4 Nov 2015 18:04:26 +0000")
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87y4ed8up0.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Correct 'change' behaviour
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2015 18:51:35 -0000

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

> Doesn't the comment in the code say in essence "if it's the same type of
> qdisc then the operation is a change, else the operation is (an atomic)
> remove/add" ?  Or did I mis-read it.

Hmm, that's not how I understood the comment (nor the code). But it
certainly seems that that is what happens. Asked on netdev, let's see
what they say... :)

-Toke