From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 305B63CB35 for ; Thu, 14 Feb 2019 13:14:23 -0500 (EST) Received: by mail-ed1-f51.google.com with SMTP id 10so5781024eds.7 for ; Thu, 14 Feb 2019 10:14:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=pAOh4hROEQFOTgLnkUdmfb01QJ3kdQ6zVNqJNaSEwWM=; b=CBQDv+uV09hquLLWTLeYg8/Ge1wKI/Le3vpQqwzDV73pjQ8VqXfnZIieKBeTLNUZa7 pX5HmHNlqOHpFyAiVQD1xNmSxo94Vic7pIhKS4usUuLXH4ettKk2Vo8nW+jRq9hXUabF EcLuoggH0EUdMiwLyhOfmHEGQ8h9AYaTY1AZC5udmdHYDwN8XE6NisOGekDh31VPQOu/ yZUZR91t+8lYhGZqarVs423whKQ+v+nXRG1w++KP0WQsHC/9il9StyQkzy/5TP72gMjf 3qr4oAYZvOF+L7kLOtpY1pVigvj4to1GFE9ycCbJjpHox7+q7DvH033nADo9YDk0T4ML +BoA== X-Gm-Message-State: AHQUAuYjLtCleJzU8cvX8883TYmLhv7xsMehEA88e3YnsEyZjq35ZpWq HjbRv+iLkzN9ZDzoSaqhjxoiDA== X-Google-Smtp-Source: AHgI3IZeP9q4g3FaGLCufqqU3DIiZmstlryFpu22csO3LqVR0qYhP5IGUrgvYZIjFdLto+5oP4+Muw== X-Received: by 2002:a50:8a45:: with SMTP id i63mr4267957edi.262.1550168062305; Thu, 14 Feb 2019 10:14:22 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id g18sm842912edh.39.2019.02.14.10.14.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 10:14:21 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id ED5CD1825DD; Thu, 14 Feb 2019 19:14:20 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: George Amanakis Cc: cake@lists.bufferbloat.net, chromatix99@gmail.com, George Amanakis In-Reply-To: <20190214180217.13090-1-gamanakis@gmail.com> References: <87a7iymxie.fsf@toke.dk> <20190214180217.13090-1-gamanakis@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 14 Feb 2019 19:14:20 +0100 Message-ID: <87zhqys0eb.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] progress? dual-src/dsthost unfairness X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 18:14:23 -0000 George Amanakis writes: > I tried Toke's and Jonathan's suggestion, dropping the > sparse_flow_count. Tthe results are the same (fairness). > In a hash collision in this patch the host_bulk_flow_count is not updated, > does this make sense? Yeah, think so; it should be updated later when that flow transitions to bulk. Care to resend with a proper commit message + signed-off-by line (or open a pull request on github)? I figure we can put it into the github repo for a bit more testing before submitting a patch upstream :) -Toke