From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
Subject: Re: [Cake] [PATCH net-next v5] Add Common Applications Kept Enhanced (cake) qdisc
Date: Sat, 28 Apr 2018 18:05:37 +0200 [thread overview]
Message-ID: <87zi1n2u5q.fsf@toke.dk> (raw)
In-Reply-To: <20180427193901.8057-1-toke@toke.dk>
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> +static inline struct tcphdr *cake_get_tcphdr(struct sk_buff *skb)
> +{
> + struct ipv6hdr *ipv6h;
> + struct iphdr *iph;
> + struct tcphdr *th;
> +
> +
> + switch (skb->protocol) {
> + case cpu_to_be16(ETH_P_IP):
As someone was kind enough to point out off-list, skb->protocol doesn't
actually contain the protocol number of the inner protocol, so this
doesn't work for 6in4 encapsulation. Will try again...
-Toke
prev parent reply other threads:[~2018-04-28 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 19:39 Toke Høiland-Jørgensen
2018-04-27 19:39 ` [Cake] [PATCH iproute2-next v6] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-27 19:57 ` [Cake] [PATCH iproute2-next v7] " Toke Høiland-Jørgensen
2018-04-28 1:03 ` Stephen Hemminger
2018-04-28 15:27 ` Toke Høiland-Jørgensen
2018-04-28 16:05 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi1n2u5q.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox