From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 557D73BA8E
 for <cake@lists.bufferbloat.net>; Sat, 28 Apr 2018 12:05:40 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1524931539; bh=F6+gCXWlWMkEmALPM8xt2nVS9rbNeGcWbSnLGaTE4Dk=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=vmXgNu38lfltIUuv+ENDtVO3pZnQzQaNuQPMUnEcQ6gElt+a1PqYsuyGqIG6aBytM
 0H7KUZuejyW/KdtwBmyBAbEd40argp3BWh4gM8IsfkOs2GwrsG1G//JO6ztEkgcYvq
 lnmkGEAiqrctaCO6Q8adlLFNipskzn4YvoWq4S+WO4Z+rbmLMPYR2t6kChClm5oVGg
 DfqkQLRw6XefnX9ZfETvSArOsmVW1tdIzhT7LEcr+To5jyus7yuvySCvZI0DZTNZNE
 t3g1mH+Kao2REFRmFb9hlG89ViHVwwKNzAZjOZzxEGt4zT6IISPs6LugXjjLG4oB9D
 rVodeD2UcydBA==
To: netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
In-Reply-To: <20180427193901.8057-1-toke@toke.dk>
References: <20180427193901.8057-1-toke@toke.dk>
Date: Sat, 28 Apr 2018 18:05:37 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87zi1n2u5q.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v5] Add Common Applications Kept
	Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 28 Apr 2018 16:05:40 -0000

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> +static inline struct tcphdr *cake_get_tcphdr(struct sk_buff *skb)
> +{
> +	struct ipv6hdr *ipv6h;
> +	struct iphdr *iph;
> +	struct tcphdr *th;
> +
> +
> +	switch (skb->protocol) {
> +	case cpu_to_be16(ETH_P_IP):

As someone was kind enough to point out off-list, skb->protocol doesn't
actually contain the protocol number of the inner protocol, so this
doesn't work for 6in4 encapsulation. Will try again...

-Toke