Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Dropping last_len from stats collection & display.
Date: Wed, 1 Jun 2016 17:00:12 +0300	[thread overview]
Message-ID: <8A50E29E-5CEC-4DFB-9227-69EFE66C7D02@gmail.com> (raw)
In-Reply-To: <574EC9B6.90708@darbyshire-bryant.me.uk>


> On 1 Jun, 2016, at 14:40, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
> 
> Not updating another variable (memory write) for each packet may help cake's CPU usage a little.

I’ll think about this one.

I don’t think it should gate the LEDE merge (nor should it require a stats version bump), since as long as the entry remains in the stats struct, it will simply remain zero if not written.

In future the space could be reused, in which case a version bump would be appropriate.

 - Jonathan Morton


  reply	other threads:[~2016-06-01 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 11:40 Kevin Darbyshire-Bryant
2016-06-01 14:00 ` Jonathan Morton [this message]
2016-06-01 15:54   ` Kevin Darbyshire-Bryant
2016-06-01 15:05 ` moeller0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8A50E29E-5CEC-4DFB-9227-69EFE66C7D02@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox