From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com [IPv6:2a00:1450:4010:c07::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 362663B25E for ; Wed, 1 Jun 2016 10:00:25 -0400 (EDT) Received: by mail-lf0-x232.google.com with SMTP id b73so13500580lfb.3 for ; Wed, 01 Jun 2016 07:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6XligqKN1NzKxsxDGpKrRra/qnw2gEzsviRp/IjN4O8=; b=as6PdBGuR2Mr3w+EZ/eztwwm/k+BLC/0Y/sN1fgy+4Jvmb2SelkupikeNiLWN2d/o0 +xCrjVW9J3NOnoucxcKIxCS34ibawAzdP3obaApKWFfysNy6TALCj7UYomoJ4p9y2MSV OHBP3l8zkIaZZhAtlV27Aij6RAeooaKC1exAvpMFUFbSsx6gY8fkmLsnc1lNavhvV9n3 Y/NwZH3c0ONCbOUrCOamSuyPJuN+H78tqImZCRLhZCa4UMGTwzIrf9/rNQ4u62dxdbbO MluFK8LXiAqaI985rm/uUtyfUKJHJbyen80QIVbb2yXYEZ3+62BLfUYIcAhDaqHvwIKT 1phw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6XligqKN1NzKxsxDGpKrRra/qnw2gEzsviRp/IjN4O8=; b=kLGPcs8iT5AfyI2AuQYLyPO1S2ZVzji7Jd6Huq34flQIdIF9+SbmxcswfEeCbFMb/f 1OZ3zV8BeVm4NlWWHFq994lB+4gwkR/2hQTM/1JIXV8LBaqMzCKAfaQsv0Zg9S3F/cwB 5Bxfa+G5LtcLQPAbYR09ABo1MQEujYFkE2OcOLEUCIbXk3EkI4pb+H0EUimhjWmkUPEy lD0c/QLZ9pC+w5YNmoXT7JPy6dy41CrDGr3sAdOrWCp4AzT8biUZjNvNdEZc1RDoW9L7 wdVzV74a4aTY7eQQ3T8SvPOUThtzi3+GDcDnQ2Ont0Z4xJOBCesNK47O7Ur5cJ4hdPQQ rDAA== X-Gm-Message-State: ALyK8tLUiEfsrmQhXdARn+FqeyGJ7XUszbSiKVvjLZcCfq3GAqaEbnpMB2qs9geEzEaNPg== X-Received: by 10.25.153.137 with SMTP id b131mr1760689lfe.61.1464789624097; Wed, 01 Jun 2016 07:00:24 -0700 (PDT) Received: from [192.168.100.11] (37-33-56-85.bb.dnainternet.fi. [37.33.56.85]) by smtp.gmail.com with ESMTPSA id 10sm1352557ljj.49.2016.06.01.07.00.23 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Jun 2016 07:00:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Jonathan Morton In-Reply-To: <574EC9B6.90708@darbyshire-bryant.me.uk> Date: Wed, 1 Jun 2016 17:00:12 +0300 Cc: cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <8A50E29E-5CEC-4DFB-9227-69EFE66C7D02@gmail.com> References: <574EC9B6.90708@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.3124) Subject: Re: [Cake] Dropping last_len from stats collection & display. X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 14:00:25 -0000 > On 1 Jun, 2016, at 14:40, Kevin Darbyshire-Bryant = wrote: >=20 > Not updating another variable (memory write) for each packet may help = cake's CPU usage a little. I=E2=80=99ll think about this one. I don=E2=80=99t think it should gate the LEDE merge (nor should it = require a stats version bump), since as long as the entry remains in the = stats struct, it will simply remain zero if not written. In future the space could be reused, in which case a version bump would = be appropriate. - Jonathan Morton