From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
Subject: Re: [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc
Date: Wed, 25 Apr 2018 09:59:52 -0700 [thread overview]
Message-ID: <8ed8d136-1eac-82c0-bf2e-02be697729f2@gmail.com> (raw)
In-Reply-To: <87tvrz5ipt.fsf@toke.dk>
On 04/25/2018 09:55 AM, Toke Høiland-Jørgensen wrote:
> Well, as I said, 10Gbit+ links are not really the target audience ;)
Well, 640KB of memory is all we need.
>
> We did actually have a threshold at some point, but it was removed
> because it didn't work well (I'm not sure of the details, perhaps
> someone else will chime in).
>
> However, I'm fine with adding a flag, as long as peeling defaults to on,
> at least when the shaper is active (to properly account for packet
> overhead we really need to see every packet that goes out on the wire).
> Would that be acceptable?
Not a flag, a threshold based on bandwidth.
next prev parent reply other threads:[~2018-04-25 16:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 13:42 Toke Høiland-Jørgensen
2018-04-25 13:42 ` [Cake] [PATCH ipruote2-next v4] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-25 14:52 ` [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc Eric Dumazet
2018-04-25 15:22 ` Toke Høiland-Jørgensen
2018-04-25 15:48 ` Eric Dumazet
2018-04-25 15:51 ` Eric Dumazet
2018-04-25 16:06 ` Toke Høiland-Jørgensen
2018-04-25 16:29 ` Eric Dumazet
2018-04-25 16:52 ` Jonathan Morton
2018-04-25 16:57 ` Eric Dumazet
2018-04-25 18:34 ` Toke Høiland-Jørgensen
2018-04-25 18:48 ` David Miller
2018-04-25 19:02 ` Eric Dumazet
2018-04-25 19:15 ` Toke Høiland-Jørgensen
2018-04-25 17:54 ` Sebastian Moeller
2018-04-25 16:55 ` Toke Høiland-Jørgensen
2018-04-25 16:59 ` Eric Dumazet [this message]
2018-04-25 16:00 ` Eric Dumazet
2018-04-25 16:17 ` Toke Høiland-Jørgensen
2018-04-25 17:43 ` Eric Dumazet
2018-04-25 18:35 ` Toke Høiland-Jørgensen
2018-04-25 18:39 ` David Miller
2018-04-25 18:46 ` Toke Høiland-Jørgensen
2018-04-27 10:54 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed8d136-1eac-82c0-bf2e-02be697729f2@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox