From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x233.google.com (mail-pf0-x233.google.com [IPv6:2607:f8b0:400e:c00::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D4A273BA8E for ; Wed, 25 Apr 2018 12:59:54 -0400 (EDT) Received: by mail-pf0-x233.google.com with SMTP id f15so15751048pfn.0 for ; Wed, 25 Apr 2018 09:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ah4ySXZssXt+mr/jOJa6M3b2Aq/eCryiy/OZ+BuS4Vw=; b=k57HYrBk9ylLKiTKdFCLqR7p1qi4QWRRTfxZ3dpGG5Bt5vAtchkmdQmWywx0UJxpV2 rX96j67w3D4nK3KLlzYdSDVscoACdR+Qmo9Wu31UaNfsav4zfcQqH0pIVxgfNx0tF+2S c0ydJGXLFSAoaT+1to0GcsRkL8QXjc7MB1oUHeHlYpjtZlUbyJgVE5TlSg6oQ8yrcEqa XOxN+yrfhF/WPRldsLlmwM2IuB2GCCJ5z7CezYfXllmMVUG73Hv7hYObBwiFNNth+6yJ ZluR8EeN87Mff5lJsJ7jse7Va7t3vetIEoOdWjqZqs/W9SJ+xEQB6uUDV3jMEJ1MpW6E l47A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ah4ySXZssXt+mr/jOJa6M3b2Aq/eCryiy/OZ+BuS4Vw=; b=otIgVcGw8QSCvGGVecge4temHTP6jWuK2ztxcbId9MllFnrhfAlyMz2HSN6tAE9XWP nvw3JuqTz4WW+pFN5rRW/ZTDqiL4WaYuScFJK2SI3UIbODKuCWIvn8NDloY3UQLT2O7v dqcTBPq+IpRJflvaTVCqibUFl+c874uB9FyYwzRwDXmgV9c6ET1Inou5Qt1ctW/sZmBJ 0t6083kOL5EWK3YGrnmbJhYYMECzkqlrhAFPESZWRXAlTtt43uN6egqznSJjkExflfL1 TTHeZBWJ3aAMTQwuVSLv25cBlBeHJLEf4Cp6H0zdtD7UcvT2F7HLhuT4qWNt9ZYLAPql zOww== X-Gm-Message-State: ALQs6tDGHhTJ3d1rSwXu0ForCgZ0hvLg64c2xtMFzfsrswpwxxsoS7k+ J5qzNa723HroQSvq0CVqUgjj8umC X-Google-Smtp-Source: AIpwx4/WEtssdXeJD8vHKsduTiWO9It+B0AW9jpWByqlaMZ7KtIIBSWBbuIrOCRXRFZoCXzO7YUOXA== X-Received: by 2002:a17:902:3a5:: with SMTP id d34-v6mr29191946pld.103.1524675594201; Wed, 25 Apr 2018 09:59:54 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id 125sm22637003pfc.145.2018.04.25.09.59.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 09:59:53 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht References: <20180425134249.21300-1-toke@toke.dk> <878t9b5n0q.fsf@toke.dk> <6bc11ded-028f-6c8f-964e-a569b4e10813@gmail.com> <8736zj6zj2.fsf@toke.dk> <8bae2ee1-efcc-1571-2a30-5b7779de2c88@gmail.com> <87tvrz5ipt.fsf@toke.dk> From: Eric Dumazet Message-ID: <8ed8d136-1eac-82c0-bf2e-02be697729f2@gmail.com> Date: Wed, 25 Apr 2018 09:59:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87tvrz5ipt.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 16:59:55 -0000 On 04/25/2018 09:55 AM, Toke Høiland-Jørgensen wrote: > Well, as I said, 10Gbit+ links are not really the target audience ;) Well, 640KB of memory is all we need. > > We did actually have a threshold at some point, but it was removed > because it didn't work well (I'm not sure of the details, perhaps > someone else will chime in). > > However, I'm fine with adding a flag, as long as peeling defaults to on, > at least when the shaper is active (to properly account for packet > overhead we really need to see every packet that goes out on the wire). > Would that be acceptable? Not a flag, a threshold based on bandwidth.