Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: toke@toke.dk, cake@lists.bufferbloat.net, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier
Date: Wed, 23 May 2018 22:31:53 +0300	[thread overview]
Message-ID: <91739F64-20B7-4C56-A7A3-AB8C71B9437C@gmail.com> (raw)
In-Reply-To: <20180523.144442.864194409238516747.davem@davemloft.net>

> On 23 May, 2018, at 9:44 pm, David Miller <davem@davemloft.net> wrote:
> 
> I'd much rather you do something NAT method agnostic, like save
> or compute the necessary information on ingress and then later
> use it on egress.

We were under the impression that conntrack was the cleanest and most correct way to convey this information between qdiscs.  Frankly it's difficult to see how else we could do it without major complications.

Remember that it takes two different qdiscs to implement ingress and egress on the same physical interface, and there's no obvious logical link between them - especially since the ingress one has to be attached to an ifb, not to the actual interface, because there's no native support for ingress qdiscs.

What's more, there's no information (besides conntrack) at ingress about the "inside" address of NATted traffic. There might be some residual information for egress traffic, but communicating that to the ingress side feels very much like we need to reimplement something very like conntrack.

If not supporting "alternative" NAT mechanisms that don't register their data in conntrack is the penalty, it's one I personally can live with.

 - Jonathan Morton


  reply	other threads:[~2018-05-23 19:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 13:57 [Cake] [PATCH net-next v15 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-22 14:07   ` Pablo Neira Ayuso
2018-05-22 14:11     ` Toke Høiland-Jørgensen
2018-05-23 22:46       ` Pablo Neira Ayuso
2018-05-23 23:25         ` Toke Høiland-Jørgensen
2018-05-23 18:44   ` David Miller
2018-05-23 19:31     ` Jonathan Morton [this message]
2018-05-23 20:04       ` David Miller
2018-05-23 20:33         ` Jonathan Morton
2018-05-23 20:39           ` David Miller
2018-05-23 20:38     ` Toke Høiland-Jørgensen
2018-05-23 20:41       ` David Miller
2018-05-23 21:05         ` Toke Høiland-Jørgensen
2018-05-23 21:20           ` David Miller
2018-05-23 22:40             ` Toke Høiland-Jørgensen
2018-05-24  4:52               ` Kevin Darbyshire-Bryant
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91739F64-20B7-4C56-A7A3-AB8C71B9437C@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox