From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
netdev@vger.kernel.org, cake@lists.bufferbloat.net
Cc: Yuchung Cheng <ycheng@google.com>, Neal Cardwell <ncardwell@google.com>
Subject: Re: [Cake] [PATCH net-next v14 3/7] sch_cake: Add optional ACK filter
Date: Mon, 21 May 2018 14:15:11 -0700 [thread overview]
Message-ID: <92cf4a80-8e26-8a08-1b8f-e8f0c131e9e6@gmail.com> (raw)
In-Reply-To: <152693495862.32668.11914023983598526087.stgit@alrua-kau>
On 05/21/2018 01:35 PM, Toke Høiland-Jørgensen wrote:
> +
> + /* 3 reserved flags must be unset to avoid future breakage
> + * ECE/CWR/NS can be safely ignored
> + * ACK must be set
> + * All other flags URG/PSH/RST/SYN/FIN must be unset
> + * 0x0FFF0000 = all TCP flags (confirm ACK=1, others zero)
> + * 0x01C00000 = NS/CWR/ECE (safe to ignore)
> + * 0x0E3F0000 = 0x0FFF0000 & ~0x01C00000
> + */
> + if (((tcp_flag_word(tcph) &
> + cpu_to_be32(0x0E3F0000)) != TCP_FLAG_ACK))
> + return false;
>
Why ECE/CWR/NS can be ignored ?
DCTCP would disagree, and maybe BBR soon.
next prev parent reply other threads:[~2018-05-21 21:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 20:35 [Cake] [PATCH net-next v14 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-21 23:34 ` Marcelo Ricardo Leitner
2018-05-22 8:45 ` Toke Høiland-Jørgensen
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-21 23:45 ` Marcelo Ricardo Leitner
2018-05-22 8:44 ` Toke Høiland-Jørgensen
2018-05-22 20:22 ` Marcelo Ricardo Leitner
2018-05-22 22:06 ` Toke Høiland-Jørgensen
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-21 21:15 ` Eric Dumazet [this message]
2018-05-21 20:35 ` [Cake] [PATCH net-next v14 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92cf4a80-8e26-8a08-1b8f-e8f0c131e9e6@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox