From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 77AD23CB35 for ; Thu, 19 Jul 2018 11:22:12 -0400 (EDT) Received: by mail-pg1-x543.google.com with SMTP id r5-v6so4069763pgv.0 for ; Thu, 19 Jul 2018 08:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=urszima9m2AX+/YawepJahee7ZVM2fAzYcWTPyCwg3Q=; b=TvDubfUc7tqyLX9ERrSlxSqmrgy+K2+eLRomMwzi62yYRxSBzYUe4F97XkviwOsutK HJnBaYkb53Df/y18W7CGx+oz2MdZ00keCKkvtygHPICIcP0rWGwYATSR4/xAoM+VSs4G /1PYhvJ+NGFZ9U1gH3R17DayZqM8rDVH8u6kXuXovvIljZmgAvRjL6N2mq8RMQp6qJaw acrW/+y4DJn/aMmFpZd7CzsnnKSjBoU9rJfKBnPG4vvSe4fQXvjhlaEogD4ei0i64mA4 irvYqOEhtis3pn2v1aitLDN3dccdfTmOfjt31p8t8FzQkN/d0CHia/Nu0UzphxmXvGxW QzEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=urszima9m2AX+/YawepJahee7ZVM2fAzYcWTPyCwg3Q=; b=VFK4mgaqL9VyJjPYe8HG1/eSdKYkQj7MQsBzp7Yzu9orgFDbT8wiVz2fMZHA7F1Q/l rkFRa1erFhaviuie7KJmqjRJU0yg6NmLjCgrFNDkQbMP0nDAEBmIfWDAPaucXOUHPMy1 K3a5P+YkU3liwKZKwfsv2cwrSZ2YPv4rPPSQpBPFvsOIdbe8TBYx3ZwZMpqgzFjFvu0I C/4+JoZpuaJ/rMszoMZWvO0rMI5hJUo2m8WwBP277L/gR5j008avbY45kZC0Wy8l7XuK O9n5TwB+akzB+C2mZTs7p0gy72hFnuSZ/ijU8Lqos41AVNng7buw5K+W1g8DDNDmeW0A st0g== X-Gm-Message-State: AOUpUlF8mvOUGF8E4PXythRXKxDhxKbUCDT+c1aGTWahHdtAFftsronx EAuOpb3/FGreZOrhhPgcQug= X-Google-Smtp-Source: AAOMgpft/9W7gfU0X2T+0F8kxlD1YE5TrwCnFtGAKjTxovNxd/B8AhJyR4lMzgfKW1pEKEBDmYNB3Q== X-Received: by 2002:a65:64c8:: with SMTP id t8-v6mr10424716pgv.110.1532013731787; Thu, 19 Jul 2018 08:22:11 -0700 (PDT) Received: from dsa-mb.local ([2601:282:800:fd80:41e6:c9c0:c223:a927]) by smtp.googlemail.com with ESMTPSA id r16-v6sm12831980pfe.173.2018.07.19.08.22.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jul 2018 08:22:10 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht References: <20180716163926.4826-1-toke@toke.dk> <87bmb34htz.fsf@toke.dk> <87r2jz2qxi.fsf@toke.dk> From: David Ahern Message-ID: <951130c0-7eb9-19a0-e418-04f8263ab97c@gmail.com> Date: Thu, 19 Jul 2018 09:22:09 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87r2jz2qxi.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 15:22:12 -0000 On 7/19/18 9:20 AM, Toke Høiland-Jørgensen wrote: > David Ahern writes: > >> On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote: >>> A few comments below; will fix the rest. >>> >>>>> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); >>>>> + print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidth, b1)); >>>>> + } else >>>>> + print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", "unlimited"); >>>>> + } >>>>> + if (tb[TCA_CAKE_AUTORATE] && >>>>> + RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) { >>>>> + autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]); >>>>> + if(autorate == 1) >>>>> + print_string(PRINT_ANY, "autorate", "autorate_%s ", "ingress"); >> >> This just caught me eye as well ... why the '_' after autorate? > > Well, the parameter is called autorate_ingress to make it a single > token. When adding JSON support I picked the key/value representation > mostly because we could theoretically add other autorate modes in the > future (the netlink parameter allows it). ok, just seems odd that json and stdout representations are different.