From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DEF863B2A4 for ; Thu, 31 Jan 2019 02:15:52 -0500 (EST) Received: by mail-wr1-x441.google.com with SMTP id 96so2076901wrb.2 for ; Wed, 30 Jan 2019 23:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=EfboIx9FJKkbf/YhfL/rsit2pzAC1KHY/0AJoCrbLqE=; b=YAvItWQBPKCyorQMeVYA+d11jcW0UlK/Bd1sC/CjXKAXVScbws5u23ujtK8zx/eaVR HxeLEkePiNfhgJsP5D039ACeuoe5uy7UHdRVYaTPiSOsJsBSxyYPNmsHfAYJ9qRXWYEi gkU5XkVKfpkNLYmpfzIe8CA+opWKBROhExw6iZlD6btC2maZezFRiOM4rpLwJEBB6LaP Qh/t7xkhUWog84i2glHWGATVkIRwaLrMmhesJmUfedMMYA01sjwH01omK7qRXtH216Xe bsDasDRsvPQ750OU5oALN4RODZGco5zBi+4RRJXd8ZVBtpKIXpURxOInaCfrbd5RuUa+ z6FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=EfboIx9FJKkbf/YhfL/rsit2pzAC1KHY/0AJoCrbLqE=; b=iAmGClsBqGoPPksQ1yMT4VzPLGWHsC0dr1ONeYkUVE+IoR3U7TyHsCp95k4nYjuaIY ifcdghPCINYMRptNja2nn5XomootZkeupxwA3f91exIMy9Bm9g7MUHxYRFS7JUNN9WqF zgkeWVZ6qxDd55Vz4J8fpoQGaoE3lV8V4+lnzrnVESFwFWbA7Jzq/RzqyCYi+L/rvy3K jTqOlUA3zQRtxJN3ZCiYwHmeUryQP8MlbRubox0WDxTokKWoNbBZiFUsbERUr323FJnz hikzPVMv8I7dQQs34CFPPrYdAp+ARbA3FYo+ThbycUkj/nlu4ZvtcMszbPtq13QsWtHC A0sw== X-Gm-Message-State: AJcUukeheQWT+WAK+akQ3Wzgiol3vJT0o+i112Ioa5KHdgOJ6ttR4Hk5 110QBHx/zQlUcqDtdHBjZMvThoiGUMA= X-Google-Smtp-Source: ALg8bN6vr35nepqeCJYnAG74BXhrZSoKecj4Ck/DZ2+S7IhAs0fb2+6NEPPjQjv4RgaPY1Re3ztHag== X-Received: by 2002:adf:83a7:: with SMTP id 36mr33207084wre.13.1548918951962; Wed, 30 Jan 2019 23:15:51 -0800 (PST) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id f191sm4592923wmg.12.2019.01.30.23.15.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 23:15:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Pete Heist In-Reply-To: <87zhrhiwfv.fsf@toke.dk> Date: Thu, 31 Jan 2019 08:15:49 +0100 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <9540B582-7B7C-4846-BA40-54419DF109D4@heistp.net> References: <15FB76CC-44B2-496B-80EC-8D00AD2AF9B7@heistp.net> <87zhrhiwfv.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] lockup with multiple cake instances on 3.16.7 X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 07:15:53 -0000 Thanks much for the try, only that didn=E2=80=99t fix it yet. I also = tried changing two more calls to sch_tree_lock/unlock in cake_change to = the maybe versions (recognizing that those may have still been there on = purpose), but I still see the lockup. Even commented all the lock calls = out to make sure. I noticed that tc-adv is without xtables support when I compile it = (TC_CONFIG_NO_XT:=3Dy) in case that makes any difference. No = libxtables-dev package available on this distro. Pete > On Jan 30, 2019, at 11:59 PM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Pete Heist writes: >=20 >> I=E2=80=99m seeing a lockup with cake on 3.16.7 with 64-bit Intel = when adding >> more than 4 cake instances. I=E2=80=99m using cake and tc-adv from = head. Does >> anyone have an idea what this could be? >=20 > Looks like it's a compatibility issue with old kernels. Could you = please > check if the latest commit in the github repo fixes this? :) >=20 > The explanation, copied from that commit: >=20 >> The qdisc stats dumping was changed in 4.8 (by commit >> edb09eb17ed89eaa82a52dd306beac93e292b485) to be lockless and moving = the >> responsibility for taking the qdisc root lock into the qdisc itself. = Cake >> inherited this from FQ-CoDel, but it leads to deadlocks on old = kernels >> where the core stats dumping code still takes the root qdisc lock. >=20 >=20 > -Toke