Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: cake@lists.bufferbloat.net, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [Cake] Possible BUG - parent backlog incorrectly updated in case of NET_XMIT_CN
Date: Sat, 11 Jun 2016 19:41:23 +0300	[thread overview]
Message-ID: <98AFD8C3-2343-4B8B-BFB0-6F877161A039@gmail.com> (raw)
In-Reply-To: <575BD5D0.4060702@darbyshire-bryant.me.uk>


> On 11 Jun, 2016, at 12:11, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
> 
> And now there's a version 2 of Eric's fix: http://marc.info/?l=linux-netdev&m=146507012302643&w=2
> 
> Does this change apply to cake?

I suppose this answers the question of which packet’s size should be used in the correction factor.  Of course, by this time in the enqueue process, the original packet length has been replaced by the overhead-corrected one in Cake, though I can save a copy for this purpose.

And there’s also the problem that we might not need to drop packets as large as the incoming packet in order to fit the latter into the queue - so this corrected correction may be *negative* (the queue is longer than before) - but qdisc_tree_reduce_backlog() only takes an unsigned parameter here.

IMHO the NET_XMIT_CN semantics are broken.  It might be better to drop support for it, since it should rarely be triggered.

 - Jonathan Morton


  reply	other threads:[~2016-06-11 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 11:20 Kevin Darbyshire-Bryant
2016-06-07 14:50 ` Jonathan Morton
2016-06-07 15:05   ` Kevin Darbyshire-Bryant
2016-06-11  9:11     ` Kevin Darbyshire-Bryant
2016-06-11 16:41       ` Jonathan Morton [this message]
2016-06-12 16:31         ` Eric Dumazet
2016-06-12 16:40           ` Dave Taht
2016-06-12 17:48             ` Eric Dumazet
2016-06-12 17:51               ` Jonathan Morton
2016-06-12 18:19                 ` Eric Dumazet
2016-06-12 17:59           ` Jonathan Morton
2016-06-12 19:04             ` Eric Dumazet
2016-06-12 20:40               ` Benjamin Cronce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98AFD8C3-2343-4B8B-BFB0-6F877161A039@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox