From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 613733B260 for ; Wed, 28 Sep 2016 02:07:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6JWJs6kPOX1pGk/UI7gme5wQW+tqTnRTmEv7hQL2D3g=; b=Fc5RRVAmohTRcyChmvnkKYPgupF/H4sPgLL87bBfUSiMSRXWbfyD/tPmm5U0ajPPIqt71wxhPsnromT9shJLiZFfRbc6FPqqi9+eKokrwOBey8YCqQIzsDtyS4z/zJyW2HyanbF4t3qiAbOSOq9x8XuNdRgFyk8JozGjGO1waSg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; Received: from [10.102.24.2] (109.159.227.69) by AMSPR07MB113.eurprd07.prod.outlook.com (10.242.81.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Wed, 28 Sep 2016 06:07:30 +0000 To: Jonathan Morton References: <3a99770e-6350-471f-72b6-b209d7d77d75@darbyshire-bryant.me.uk> <8425FD26-5C1F-42B5-9087-01D81E1ED7F5@gmail.com> <3c28ec73-36e7-dfed-fad8-1a694d4ceeca@darbyshire-bryant.me.uk> <8555AC94-885C-41C1-BE12-40C3C3E96810@gmail.com> CC: From: Kevin Darbyshire-Bryant Message-ID: <99e6695c-67f9-e48a-bee7-ecb284ceca7e@darbyshire-bryant.me.uk> Date: Wed, 28 Sep 2016 07:07:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <8555AC94-885C-41C1-BE12-40C3C3E96810@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [109.159.227.69] X-ClientProxiedBy: DB5PR03CA0052.eurprd03.prod.outlook.com (10.164.34.20) To AMSPR07MB113.eurprd07.prod.outlook.com (10.242.81.140) X-MS-Office365-Filtering-Correlation-Id: f0b4db4a-6067-4d4a-af8f-08d3e765bb34 X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB113; 2:YXIOU9Cn2cus0hscmgOqtHxoceA83hYKiPGC0KsH05t9EgWJ+9UNGlodGbN53h0zKwvk9mPGKYUH6Vdls7WL1d23NkOnHTLkQBbzVUhES4iPvSo15cErtnlSNcpL/0SIO0PpfhcSsfVReSveskMjsLy1qNcj3kW3LH1Cd3N1lQ/yl6Hhv3MR+oU0g2ddDIWI; 3:UNDN8J2/E5/J3qcswPYFZsY02WEEJu3EVkHZ82SS1qTd2l3NgHo3bXDLzNLsF9u5n5CJw8lc1j71L8ipQp2Pd+0OQ/CAQB7V4MhR9GmhUf+TvR1I73D+Js9A665c0qvo; 25:VqfT5765zvC1Zr6tPdvbaL8WzVzN3BzsxZon34W6XaKD2oHcCMzWtnSXcLi902dajiJ0oy7WBJSwQi4kMFtY6boDk7XCrflJ2AYTP/f78JG1eLQuTswxE9EnSEiUZH9/sKZLVs2KKdaQBKm15Wl4dh5aOXBrd77WymTvSjf74c2klFaSnJrH2Yf4hJ+KTlGfe3ipt9rzOTSvB6yucnXqXSKPV0H9DsJNLGvMsIOz82bmDEj2BgM/tWjAURABl8mtGW3gKxZVhXMjVWYZY+nVB6pmLOwpaoKh7Am1T6VsV+vKEBOYJCeLK2/39iKXOP5S5vgqLsDk1qrJEmWnf8jNiMSdry5sDTKKl/29tGE/AdYGDYTApmDMr8pdO8aLk/fLQWi8cn7P0+KBO1khfbz9L9oSTC4Up76sFfsodMo8IQQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB113; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB113; 31:wqXpF7pV5ra7kMZ1MyADPjvM2qBFXp7IJ5nBsIdx1es2cMjNfQAPrcjJ0ETuZ/7HiZKplivJ8SM0d9a5dGKdMNRZrrPNaXRuZ4k5siJXqlq++RwnpqBKxc1ZrcrEnJ2Vm4CcjVYIVcJx4Wzx+hKuWG+fOv+TCwGjJmfO59iNS2RTzWMcHzwjMX3DJX9W0TXCjBB9oTMdAPJFLlyVjzLzqE9fJB1CQBljSnPahx9MMxI=; 4:BTEk6ChZI2vuCQT8IDQ+qYvl6O1aXMo0+N3qPggzl5ErzMOHgRg4Os4hU245MUx2zDX3cUV2zGmc/XmP6oD9c7TDcJLij3ZcQHXFxWlKDhJjNCmpWMVuzg+LjeImVkmrCRB9PACwVzCArBC5ufr5aRQIcZMtnhp7Y70kV+vHqueKsZOjN7pY7z4521df2yJKK26JdHsLVhA1nI2aY7E+2LLFqtP5AB4hVF/70pm5aM3Qw+jOYXGDRegKUUSWxgbUyDBaauYFdZgg54nfjEeDsle31D9daEJkML+jLnTlOYHFIEtTC9X8Z3Gu8kQEOR2rpmp93ldHVTNEz5/cXhLnph54mlgHvK7c4rHFQpTkNZpKpHtb9vEeI42/FBJ6Ne97eYsEuvbzO1z9lTgMHPYIso2C9lq/HpS+po00ga151v4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6043046)(6042046); SRVR:AMSPR07MB113; BCL:0; PCL:0; RULEID:; SRVR:AMSPR07MB113; X-Forefront-PRVS: 0079056367 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(24454002)(1411001)(65956001)(7736002)(4326007)(74482002)(5660300001)(19580405001)(19580395003)(110136003)(97736004)(47776003)(4001350100001)(101416001)(65826007)(50986999)(77096005)(189998001)(54356999)(81166006)(81156014)(93886004)(42186005)(8676002)(31686004)(76176999)(31696002)(36756003)(42882006)(92566002)(6916009)(2906002)(64126003)(2950100002)(305945005)(86362001)(7846002)(50466002)(66066001)(65806001)(105586002)(23676002)(68736007)(83506001)(6116002)(3846002)(33646002)(106356001)(586003)(2870700001); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB113; H:[10.102.24.2]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIxMTM7MjM6RG9JRmEwNUdPVWcralk2ZmJmazRVQWZ5WEJB?= =?utf-8?B?ZUpCbFp0bU9lY0xPZUJINWowZ1hTeFJlem9lR1dOUFl5WkFBWTlrTmx5YzVV?= =?utf-8?B?MTF1YnpSRXlFbnZDY2N3aWJuMlppQUlpamluZ2RWRktlRE01aXY5a2hxTGlH?= =?utf-8?B?SGd2SE5kWituc21RUnNIVzNLbEI4Ri95ek9iWENLc1hxKzNCZ013N1c2N0xH?= =?utf-8?B?L3pSTzVyZUFlb29WM2xyOE9mL3dSTHd5Y2c3eVhrMUpjTE9FNlpVazVnZmRw?= =?utf-8?B?bGc0NXJueXNVdG1lTUYzMGdiOGJHRENMbXdkUmlLQnZvUGExQm9XbDhRcERH?= =?utf-8?B?MGJuRERxT254dCt6K09yYitPMDMvZm5Scys5YXpiMDVFWHB3V0J3SGI1Um5W?= =?utf-8?B?TFRTd2lKbDZpR1I5Wk5Rb24zSnZRNUpCZFlmdTZHZWsyMzZrSUtoYlRmb0Rp?= =?utf-8?B?QXpGRHdWVGpweTQ2TGtXY1BFc3BQUUpLQkpDeUFPMFJ2cVh5Z2t4YjNwb2NK?= =?utf-8?B?NWdRS1UzNjFYZTJHM2xpdXRING0wcml6RmFQckxKRmJkUlk4M2VWTjZ2RDI2?= =?utf-8?B?QWx0aUorUjMxZ3NLMWtMeG1VQ2JkbGtKN0J1WXRDR1JvV0ZYWllNekl3aExn?= =?utf-8?B?dnZGSHpjTWh3TGIyL1N3amFvMm8rbkZJWmQ3d0w5WmtVTEQ4VkY5Z3drTHBu?= =?utf-8?B?NHRDNkF3U0ZSY3RUcFVNNjRKeE4xQm1mTThoTjRrZjJUdEk0Mkp2N2VJY1pq?= =?utf-8?B?VGJWZndDTVdqTGY0bXFHRFJ3ZjRRclplU0c2ZzdwMTVvaEUrTlhtVzR5TkNN?= =?utf-8?B?T2lhcDJQTGVaMFZab3VuTnMxc1UwKy9zaU92NXdxeDZnL2huMGJHWURPcmxB?= =?utf-8?B?TndQc0h5VlM1cDlhbWRUeUVsM2R1ZTM4QTdWZk9MMDYwM20yUVBQMGtSdTVU?= =?utf-8?B?R3VhUEJxaCtTWHcwOVZVdVNHVjFBN1hmTm96a08zUDc2Nm5aays2TFpzd2x6?= =?utf-8?B?TndoM2twazV0NG5JVEdEWGtDMmlEQU1QSmFqczRrbzREb3BXTjBTQ2wwNitx?= =?utf-8?B?YTZ0KzJNTXlXQ1pvWTBsK0pMcWMrK2ZLOXNDOGJrb21MUUxTM0gwQkFvaVds?= =?utf-8?B?VlNwNG5oK0JYVVpyVlBKSnVFZUhYZU1iQ1BhcHE1VllURHRXTGtXbEJzcjdR?= =?utf-8?B?c0JGTkloK2Q4M1hVbEVpaEU0ekNGRzQybVFsSG45amJZbnVxelpvRlRLTTZK?= =?utf-8?B?OFk3eGtEWnYrNGZOTXZjQVFBd28zZVNybkI4TG5XSlVQdXR1VlltdmlzWkNZ?= =?utf-8?B?cnlkOWVTMFBkbHVjVk1mOEFDUFhBd2NIdkgrRlJIcUVNQ0pxclBuK0ZWVkp2?= =?utf-8?B?MGJuOVp2WGlhemRmUkdsVUJic3R2MHd6UjV4R05lTmorRStyV1N6RkNxT1kz?= =?utf-8?B?Z29iRll4MndZeG5JajNTUzVXaSt4bnFiMlp4WVNYQ0xKUlFQVzZMRnlhYU1m?= =?utf-8?B?M3BrMGY4NnBTWkFtK01hSjhWUjNPd1c5dkVUd1FBS0gwQ1luZkZJamNhWDZK?= =?utf-8?B?Y1Jzc29BNnN3SlE5am5WZE0xLzlHcDBRYmNSd3JsQnN1WGFhVWxYdmZpdDE4?= =?utf-8?B?c2Fsd1ppbGhkQjJLc0FMK1RxTUdRZlhmY1NlSW8xclBlN1BIaStJbFNZZXo3?= =?utf-8?B?SnhRcEUvTVptV0FkY3lxTHNlVFBVa0FQNHdhd3BPbzJkVHk5NWVUQjV6NFor?= =?utf-8?B?b0owSHRLVnR5dGtMUW5MSmdvNlB6VlJ4UXNkazg5U09MeDgzbkppa3ZMM3Qw?= =?utf-8?B?L3JrSTJZM0w1cytLNmNncU0yL3RwanNqUUxtajZQV1JKcjV4NGhMUDJLT2NS?= =?utf-8?Q?/iZDb8AcXQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB113; 6:DwYGFBUwrhMj7cGL6cbS+GXcs0SG/HiNO1p2XbibtW1QwDyZvzEsKgqsPHXMtkOaArGGdrezfzlcjnhHA0JjrZ2qK3h4/SDSOz9UVYgOLsysEOrYEafupQ8n9dyibL39cwBMT+/ilrWh/H4vS/aeQqdq292hmuM0Yf9befgAF0RcpKHN+KgGBuraTgF26kPmcZVy/Rr5WX6UZsrUdAYRLry1NKT5xkOB8b8vQAbzI0fR33WFj3rjx182RWvCPWMZNV+zjfbT3XDQIBI2A/N2zqAZro9MTGR3Lnpvu24svI/BIA2oQey/kaz9yOB5tD/f; 5:tsQDlySqfTp8N+CfK+Rffznv7M34AWlLLsy0/o+3SPlkyaVQ62g4QFBJWmq8SfQ6fGgtujbACd25oyF6MHoYXQNEQLmR8nVQDbhN8UQyHJuV8+DOEdjd6ZhcwKJ/38KCHBrF4TaGA6DzMy0WnUn6HQ==; 24:Y5NzAUoMbnngz/1GzX7M5TdESWCpY6JphQyzAtJuw5rcQv/3rYKatZUeD97iaqJJQc2qf8ZFWlR7gLWkkjqEwL8sJAvYIk1o2PUPPcWbBV4=; 7:jNWrLzWviwfC74TaCkiHBf5VRBO3szapKhOH6i0xWI5X0fF9C8aCkqGM/4VDLBTJsYoTg62PM3I/tjhZ0qo0WKRAYiAd6svuXpEJTbvaEGBle5phKDrbiXP0fgmAHcYQ3jkoGZQkZwaoGv0HOicMdvCsGvLtYjxYxExymXwocdR2Kh86mC8YFGQ+X9Ax/IQtY61ajunva0EfcStOhu9NKABNMhqof///HbGtyl3cmmh2SYsE61eDlIne+zYv4EynebCBK2gZSXDcTyqtbFDNiYcOa/bEDE5BBHkXbPWU0of6dJ60g+7mZwc13/X0tpKr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2016 06:07:30.6517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB113 Subject: Re: [Cake] de-natting & host fairness X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 06:07:31 -0000 Two buglets found: in sch_cake - the atm/ptm flag options are not passed back to tc userspace correctly - ptm isn't sent back. in tc/q_cake - the additional pre-set ptm+overhead options don't set 'overhead_set' so the overhead doesn't get used. On 28/09/16 04:06, Jonathan Morton wrote: > >> On 28 Sep, 2016, at 05:56, Kevin Darbyshire-Bryant wrote: >> >> Does this need to be another variable/parameter or could it be the next bit along in the flow type? > > I’ve already pushed it to the ‘cobalt’ branch, so you can see how I’ve done it and start testing. I’ve verified that it compiles, no more than that so far. > > For configuration, there is a separate flag parameter passed. Internally, I’ve used another bit of the existing flow_mode field (but not the next one along). The latter is also how the configuration is read back out again to tc. > > Overall, the patch ended up much smaller than the original. Switch statements in C are actually quite verbose. > > - Jonathan Morton >