Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	Networking <netdev@vger.kernel.org>,
	cake@lists.bufferbloat.net, "Yuchung Cheng" <ycheng@google.com>,
	"Neal Cardwell" <ncardwell@google.com>
Subject: Re: [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter
Date: Mon, 21 May 2018 11:17:05 -0700	[thread overview]
Message-ID: <9e0f206d-9800-cc0d-4ff3-da06b535d4c7@gmail.com> (raw)
In-Reply-To: <cc55420f-e5c4-c699-7af9-ff273487ef18@gmail.com>



On 05/21/2018 11:08 AM, Eric Dumazet wrote:
> 
> 
> On 05/21/2018 10:35 AM, Toke Høiland-Jørgensen wrote:
> 
>> Ah yes, sequence number wrapping. I was thinking I needed to deal with
>> that, and then got sidetracked and forgot about it. Will fix.
>>
>> Other than that, do you agree that this approach to SACK and header
>> handling can work?
> 
> Unfortunately this does not handle dsack (RFC 2883, and  3708) properly, I believe.
> 

Since I will be traveling for the next ~10 days, with possibly no Internet access,
or time to review patches, please CC other Google TCP experts for the next versions.

Thanks.

  reply	other threads:[~2018-05-21 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 16:24 [Cake] [PATCH net-next v13 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-21 17:18   ` Eric Dumazet
2018-05-21 17:35     ` Toke Høiland-Jørgensen
2018-05-21 18:08       ` Eric Dumazet
2018-05-21 18:17         ` Eric Dumazet [this message]
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e0f206d-9800-cc0d-4ff3-da06b535d4c7@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox