From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3C6133BA8E for ; Mon, 21 May 2018 14:17:07 -0400 (EDT) Received: by mail-pl0-x244.google.com with SMTP id ay10-v6so9274652plb.1 for ; Mon, 21 May 2018 11:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=U9vg6wWsJ12cYwiT/7Q4NVkvueViUanF2F/N2NLixe4=; b=afUY9uUA75SyxtQDfqX3d8twekb6JU8AxO7f4bR+1+zTqn8iPPtlquBT8g7mUUVDbi Ri2Na9gqiEEZLugvmXap1z3QxDYYxXl4vUOd5J5/yvq30ITxoA0uF0hNaLgUHVvbHCem k2cGJttmR325OM+3PZPQx28PwN02K2dvu8PBnXsShCy1SOGZuf34YalbbnKCMyYoMC+u ZniQvW3SRYRABawbdstYxewL1gHoMKxJKTskcGl+Uh1AVhQqsKkmQTYwIoazfkXvN3Sl kk366JIiI8pcB3PYcX5RPYbbyVv9VvX/fcYd0/Si0SyFZGGUv7M1sFxI2nH9UQC42Zt8 AryA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U9vg6wWsJ12cYwiT/7Q4NVkvueViUanF2F/N2NLixe4=; b=cvnLWbpj0pSCDOHyaR/dQ0GD+EDzVoPdgXOH7osX5z5qmggB8wclwj4sAgPVrU2odk OB8DCCOTFWDbvbbYIdF//TfDAJ9/zUU8RBuens1DmIovqv5hyTR61k1IQqXtdKTEhXp2 PTj5RzSVYzILwLUdvAYZp3e1fAlrj0NW3E7/2+7gT6EoyWbqv/SEHjsbK09YC/yqZB44 el+aeJ7B0ykDa4wA9U22kS0Wm9gtUFoAVkrgS9iEXMroe969Ug01DAQ08ueQHJbVq3q2 NVuKBinvD4jQccb02nn5CowhyIYmqkOQat3Bm2Urou1pSZf3WydT4EnpAKxvPu652+R2 DfpQ== X-Gm-Message-State: ALKqPweMKB3ISpIPA3DnAMeZ+dTS6JmaAj7SOWbvrtTtpqeOjZMnmmew zJmINYiHviDnTHW7lCZRHPg= X-Google-Smtp-Source: AB8JxZrtQ9d0HbBcWpPFqRo139O8TZtljAuqotSObCy1uyPkWzWM/iROzjIlX5KJU6oAxCeQtW4faA== X-Received: by 2002:a17:902:1e2:: with SMTP id b89-v6mr21580216plb.279.1526926626515; Mon, 21 May 2018 11:17:06 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id b29-v6sm27615603pfh.155.2018.05.21.11.17.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 11:17:05 -0700 (PDT) To: Eric Dumazet , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Networking , cake@lists.bufferbloat.net, Yuchung Cheng , Neal Cardwell References: <152691970035.4083.3349902669266371765.stgit@alrua-kau> <152691985736.4083.3416150561524698541.stgit@alrua-kau> <87r2m4ykrc.fsf@toke.dk> From: Eric Dumazet Message-ID: <9e0f206d-9800-cc0d-4ff3-da06b535d4c7@gmail.com> Date: Mon, 21 May 2018 11:17:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 18:17:07 -0000 On 05/21/2018 11:08 AM, Eric Dumazet wrote: > > > On 05/21/2018 10:35 AM, Toke Høiland-Jørgensen wrote: > >> Ah yes, sequence number wrapping. I was thinking I needed to deal with >> that, and then got sidetracked and forgot about it. Will fix. >> >> Other than that, do you agree that this approach to SACK and header >> handling can work? > > Unfortunately this does not handle dsack (RFC 2883, and 3708) properly, I believe. > Since I will be traveling for the next ~10 days, with possibly no Internet access, or time to review patches, please CC other Google TCP experts for the next versions. Thanks.