Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure
Date: Wed, 7 Mar 2018 20:37:44 +0200	[thread overview]
Message-ID: <A0ACB8C9-D540-4C57-A9F2-04C5C68FD066@gmail.com> (raw)
In-Reply-To: <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk>

> On 7 Mar, 2018, at 8:27 pm, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
> 
>> Are you using the latest kernel code? Those values were added in an
>> incompatible manner, so if you don't have userspace and kernel code in
>> sync they'll be garbage, basically…
> 
> I’m using latest commit on kernel space sch_cake cobalt branch and identical user space tc/q_cake.c to tc-adv repo.  It’s not just those new values, overhead, dropped, overlimits, requeues are all long standing parameters.
> 
> All the values, including the new, worked just before the big json conversion.

Supporting this, all five of the new fields are u16 or smaller, so are incapable of representing (or being misinterpreted as) values in the millions.

I haven't looked at the converted code yet.

 - Jonathan Morton


  parent reply	other threads:[~2018-03-07 18:37 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26 15:08 [Cake] [PATCH] Split tin stats to its own structure to decrease size of tc_cake_xstats Toke Høiland-Jørgensen
2017-12-26 16:28 ` Dave Taht
2017-12-26 16:32   ` Toke Høiland-Jørgensen
2018-01-27 13:05 ` [Cake] [PATCH v2] " Toke Høiland-Jørgensen
2018-02-09 12:58   ` Jonathan Morton
2018-02-09 13:08     ` Toke Høiland-Jørgensen
2018-02-11 17:26   ` [Cake] [PATCH v3] " Toke Høiland-Jørgensen
2018-02-11 17:26     ` [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure Toke Høiland-Jørgensen
2018-03-01 11:02       ` Jonathan Morton
2018-03-01 11:06         ` Sebastian Moeller
2018-03-01 13:59           ` Toke Høiland-Jørgensen
2018-03-05 23:08           ` Jonathan Morton
2018-03-06 11:17             ` Toke Høiland-Jørgensen
2018-03-06 11:46               ` Jonathan Morton
2018-03-06 12:10                 ` Sebastian Moeller
2018-03-06 13:08                   ` Jonathan Morton
2018-03-06 13:18                     ` Sebastian Moeller
2018-03-01 13:59         ` Toke Høiland-Jørgensen
2018-03-04 11:14           ` Toke Høiland-Jørgensen
2018-03-06 15:56       ` Stephen Hemminger
2018-03-06 18:33         ` Toke Høiland-Jørgensen
2018-03-06 21:06           ` Toke Høiland-Jørgensen
2018-03-06 22:31             ` Jonathan Morton
2018-03-07  8:50               ` Toke Høiland-Jørgensen
2018-03-07 10:08                 ` Kevin Darbyshire-Bryant
2018-03-07 10:31                   ` Toke Høiland-Jørgensen
2018-03-07 10:36                     ` Toke Høiland-Jørgensen
2018-03-07 11:08                       ` Kevin Darbyshire-Bryant
2018-03-07 11:28                         ` Toke Høiland-Jørgensen
2018-03-07 11:59                           ` Kevin Darbyshire-Bryant
2018-03-07 12:59                             ` Toke Høiland-Jørgensen
2018-03-07 14:21                               ` Sebastian Moeller
2018-03-07 14:30                                 ` Toke Høiland-Jørgensen
2018-03-07 15:25                                   ` Dave Taht
2018-03-07 15:52                                     ` Toke Høiland-Jørgensen
2018-03-07 17:26                                       ` Dave Taht
2018-03-08 22:29                                         ` Pete Heist
2018-03-07 18:27                               ` Kevin Darbyshire-Bryant
2018-03-07 18:35                                 ` Kevin Darbyshire-Bryant
2018-03-07 18:37                                 ` Jonathan Morton [this message]
2018-03-07 21:34                                 ` Toke Høiland-Jørgensen
2018-03-08  0:49                                   ` Jonathan Morton
2018-03-08  7:59                                     ` Kevin Darbyshire-Bryant
2018-03-08  9:21                                       ` Kevin Darbyshire-Bryant
2018-03-08 10:32                                         ` Toke Høiland-Jørgensen
     [not found]                                           ` <D8A90884-6DAE-42A6-A680-CD11599DDD97@darbyshire-bryant.me.uk>
2018-03-08 10:57                                             ` Toke Høiland-Jørgensen
2018-03-08 11:09                                               ` Kevin Darbyshire-Bryant
2018-03-08 11:14                                                 ` Kevin Darbyshire-Bryant
2018-03-08 11:21                                                   ` Toke Høiland-Jørgensen
2018-03-08 18:32                                                     ` Georgios Amanakis
2018-03-10 15:56                                                     ` Kevin Darbyshire-Bryant
2018-03-10 16:30                                                       ` Luis E. Garcia
2018-03-07 11:07                     ` Kevin Darbyshire-Bryant
2018-03-07 11:19                       ` Sebastian Moeller
2018-03-07 11:31                       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A0ACB8C9-D540-4C57-A9F2-04C5C68FD066@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox