From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1464E3CB62 for ; Wed, 7 Mar 2018 13:37:49 -0500 (EST) Received: by mail-lf0-x242.google.com with SMTP id f75-v6so4696891lfg.6 for ; Wed, 07 Mar 2018 10:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Bjrjiqt1lVczrrscmDLbxgzpFpkpyHEEHE+7bQDLWOo=; b=rSW/GbDLyIQsnX0RTsV2enG9KulqvgW2cBeTuWNIl5v52wV0NdsvxfE2skXop5mlJ1 9qV8Y3wt+KZ0nRD32aYpirHuHFCww+j7U+H1Mp5cijBt7pnIyR6lLOXY+oDjFJk+0Gx7 th5QxK/yWW5QTilfW17gi7VgRpZIxlZcKeE6fk2Zxu5CssFfqIkaJ4Vg++JqPppevQPO MPvsnaOG63G5yeNPuenhSnpkK1TsWLzvcxU9PXcu5oQ/t2XuA9i7sV63Lb/3JfCOjr9S zTQBzGhwnuVEDB1JnP6DnQMuHP60cOaAWKPoNF4gTbA/zOe7Li5zTNQrjUP2mTQu1sv1 u0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Bjrjiqt1lVczrrscmDLbxgzpFpkpyHEEHE+7bQDLWOo=; b=m2heeI4+JRe0VPx9w8jGEQmKcI2tmPiwW4BzJtS3CZbN1EqjXSL8nf8q4lBXPSvFHa LyE8nFQw0QPodCSIh5u7fXQqV5EyMB6bJ2Z0U2xFH4LpXGfa34qhvwj3NAHHvg3f/qCq wq4qRS3In/z7zidsXzzyVN7ujItz6UNgSXjHHvFeiRzskf40EAlJ+3euSWuyJqJTZkaj al89PAO2Q+7VxB7YkX2QbmtC2JwJPWNKDJtlgGP7uR5Beoytn6TFmncLv34j1OKjzGBA r+YXIu1fBT6+hZH4Bl4KDOstdSxqXp3AFwuecOLm8wbJGmzMQL+VSyFfSQLjobRaGBf2 3S/w== X-Gm-Message-State: AElRT7GrFZNiK9FLpQd3LEh5rtAYxWPCNtjPI7b/BjzgXr2c5vUjHIjU dontecw7N0V0S+BONsIPmRtwheXB X-Google-Smtp-Source: AG47ELvLIdLz9tuxcWduNJNmlbHve4TKj1a1pC4deQ9KUHa/ECjwlpdJuyl9Me9oiAPG6RrADaOQmQ== X-Received: by 10.25.83.136 with SMTP id h8mr16192406lfl.87.1520447867424; Wed, 07 Mar 2018 10:37:47 -0800 (PST) Received: from [192.168.239.216] (83-245-237-207-nat-p.elisa-mobile.fi. [83.245.237.207]) by smtp.gmail.com with ESMTPSA id v3sm3685796ljd.59.2018.03.07.10.37.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 10:37:46 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Jonathan Morton In-Reply-To: <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> Date: Wed, 7 Mar 2018 20:37:44 +0200 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "cake@lists.bufferbloat.net" Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.3445.5.20) Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 18:37:49 -0000 > On 7 Mar, 2018, at 8:27 pm, Kevin Darbyshire-Bryant = wrote: >=20 >> Are you using the latest kernel code? Those values were added in an >> incompatible manner, so if you don't have userspace and kernel code = in >> sync they'll be garbage, basically=E2=80=A6 >=20 > I=E2=80=99m using latest commit on kernel space sch_cake cobalt branch = and identical user space tc/q_cake.c to tc-adv repo. It=E2=80=99s not = just those new values, overhead, dropped, overlimits, requeues are all = long standing parameters. >=20 > All the values, including the new, worked just before the big json = conversion. Supporting this, all five of the new fields are u16 or smaller, so are = incapable of representing (or being misinterpreted as) values in the = millions. I haven't looked at the converted code yet. - Jonathan Morton