From: moeller0 <moeller0@gmx.de>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Dropping last_len from stats collection & display.
Date: Wed, 1 Jun 2016 17:05:48 +0200 [thread overview]
Message-ID: <A22398B0-E558-4A5C-9107-88DA88ECF29D@gmx.de> (raw)
In-Reply-To: <574EC9B6.90708@darbyshire-bryant.me.uk>
Hi Kevin,
> On Jun 1, 2016, at 13:40 , Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
>
> Gentlemen,
>
> Two pull requests https://github.com/dtaht/sch_cake/pull/26 & https://github.com/dtaht/tc-adv/pull/11
>
> These drop the collection of last packet's length for stats purposes.
>
> I've not dropped maxlen as I have personally found that *incredibly* useful in working out what overheads linux has already accounted for on a variety of connections. It is also a useful indicator of GSO/GRO activity.
I fully concur overhead deduction is hard any piece of information can help, also I note that fq_codel reports the same and I believe we all agree that Eric Dumazet knows what he is doing ;)
Best Regards
Sebastian
>
> Not updating another variable (memory write) for each packet may help cake's CPU usage a little.
>
> Done in a backwards compatible way for tc.
>
> Please ACK/NACK as you see fit.
>
> Kevin
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
prev parent reply other threads:[~2016-06-01 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 11:40 Kevin Darbyshire-Bryant
2016-06-01 14:00 ` Jonathan Morton
2016-06-01 15:54 ` Kevin Darbyshire-Bryant
2016-06-01 15:05 ` moeller0 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A22398B0-E558-4A5C-9107-88DA88ECF29D@gmx.de \
--to=moeller0@gmx.de \
--cc=cake@lists.bufferbloat.net \
--cc=kevin@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox