From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DAA793B25E for ; Wed, 1 Jun 2016 11:05:52 -0400 (EDT) Received: from [172.17.3.79] ([134.76.241.253]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MUoma-1b0Ic53TsC-00Y6o3; Wed, 01 Jun 2016 17:05:49 +0200 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) From: moeller0 In-Reply-To: <574EC9B6.90708@darbyshire-bryant.me.uk> Date: Wed, 1 Jun 2016 17:05:48 +0200 Cc: cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: References: <574EC9B6.90708@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.2104) X-Provags-ID: V03:K0:g9TmKPCTacjoA8V7JK+mdTsDagabr8bXBUCF/Q3yZWX7OF/W/tq QtvSiiEKQnsvkYHaFX2Ds5xT9kB44JuGnLtP9gVLPChFG7ZGUF2vpHtjZ6fEQwGHXCEHYRX TJS/a4MAtA0Qw4b+VbuBHHICirLdrJP7QGAIVmnIRdcup11RloBStoHeWYAaEsLpg0J9n1P Kt8DeL0OBQHKt8ys81meg== X-UI-Out-Filterresults: notjunk:1;V01:K0:hnx8lbLiLhQ=:pgS44Q/VyGe6LGsBf8e6pz kvWCcdSHu8s+4CLFqZmILAsXji0B6aTr5lamuMqPCzuaCX05ByjczlhQVcuin9nHsEWNdv4kq l4krI4MWV78R4nat+KjYwU3bMcUoLQZ3zDcQ4EgRvxOqkjTcf8LKyiej03RBeKdI90CsYuiq/ LOyfzu546nVCUGsh3Nn7CqGp5peRNnXTDn0IeYDh3hqHXw/jIA5gEEjkPfqOXMGozFgmUjik/ 7t9TJiPJdrTkPWLvwj7c4RLNw5Nu3aK/zXdwAsrrcMATdOac85Rn8aRO9n/1J7xON5pfaz5uP WB4hLu0sk0ihcF82faISr08UvN09YkkeBocCW0zpMzWFUJ3LKfNLJc7YTaDzYf7KP8SwZybT0 NFyqG8r/0ZGxRWPR9u2c2VyMo0j2jHoZ4bw9sBPCAnYo15n1P00YQJkzPghepXhuB9YzLseH5 RM1u3448QmMzdUFinjAPgLQG19/Spy6QylXI4ktaXlMaKz91LqCARcvWIeaMmHEqx2XmvxY8o u1czj07wZAAe31FvNWrffeVFIa/4hNwS73fsIXR8OvSdhyznUB2EmrbybC0aPagNWyCil5UR0 d+0fBKOA67gCsaSGeqgKwEjNkutckm6s28/HcsmszWrmWpG9VJJbJFmqVm4v3vdNscUaabvbe fVkjQNyZhQpf9Qqlw1s4gUSvmiqEI9lpl4QMfGV6b1rthzhnttuD9iKziVYvNX6PxSsHIMEvW jNugSzp0wq9oV5WnLukcCRyk2GGWuplvluQW5NL/AtbqdbpekJyIGKHmooXm2BRDTj8g5xuaB 4Rtmk8g Subject: Re: [Cake] Dropping last_len from stats collection & display. X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 15:05:53 -0000 Hi Kevin, > On Jun 1, 2016, at 13:40 , Kevin Darbyshire-Bryant = wrote: >=20 > Gentlemen, >=20 > Two pull requests https://github.com/dtaht/sch_cake/pull/26 & = https://github.com/dtaht/tc-adv/pull/11 >=20 > These drop the collection of last packet's length for stats purposes. >=20 > I've not dropped maxlen as I have personally found that *incredibly* = useful in working out what overheads linux has already accounted for on = a variety of connections. It is also a useful indicator of GSO/GRO = activity. I fully concur overhead deduction is hard any piece of = information can help, also I note that fq_codel reports the same and I = believe we all agree that Eric Dumazet knows what he is doing ;) Best Regards Sebastian >=20 > Not updating another variable (memory write) for each packet may help = cake's CPU usage a little. >=20 > Done in a backwards compatible way for tc. >=20 > Please ACK/NACK as you see fit. >=20 > Kevin > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake