From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4C9EC3CB48 for ; Tue, 6 Mar 2018 07:10:39 -0500 (EST) Received: from [192.168.250.102] ([134.76.241.253]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MFxwA-1evyxu0TiQ-00Esm7; Tue, 06 Mar 2018 13:10:36 +0100 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Sebastian Moeller In-Reply-To: Date: Tue, 6 Mar 2018 13:10:34 +0100 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <12C7E818-E440-40A9-AE67-C6EDD7F87FB6@gmx.de> <08E2549E-769F-4AF3-8D34-22A149432463@gmail.com> <87ina91mir.fsf@toke.dk> To: Jonathan Morton X-Mailer: Apple Mail (2.3445.5.20) X-Provags-ID: V03:K0:oy2dB/rByf+2i7S65rlcxmsdaAwTVshuF71PNwiaDxBQmGmYhRW eQvneUJT505DBm4XpyJBE8A6vDoKciPl1X1XEP5gsaUylKapV2X5Rlsmq10MzeW0nnFnOXx nB3/WcwCr5YBFnAA4Tr+ICJUaSbtRWKP92u4rLiTYEtb5h8Uqdl3E9rctQ38RGuLAANTR+k +iGYMd6ttoGFAiT7Dj3PQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:LIDZxHyWTOw=:iEcSCJ9fyED7xFDTpPd4/E z8i7SwO8qEJLVzTaVArHTssURvQkh0FAneMC76utC8COyP/8Iu3VwNjiOaY7wxsrNy+KkL8ov rN+Bpypr65JspeBEwuw/PxWZMR/qPkIlT2K1/hQtKDfbEtGTJVZNlqpqgghJwAlz6154PagJU vJfOHRtM1WMZSwioXKWfHnLVVC0aAlrR9JfbACKcZYrnRWxVaboYbsmOqXBl/sIMmUWao/nVd ofAYrk9N/J0zClDlq1ub4cUQbr++j/q60pL6+9iVOLwSq8IQi3IpSu6IP0F763aQhFtQ1RUu7 s/aObhPuQhkM1bJSFzXRoxbsYqyMw1EeaST2DLlPL1IPdT6nOOh0rES6VYpUkvMmRaKpUwQ4v oi5aPm3MnL2VCV0sS3uxk/B950mgVwQ4qiPeHQnmXVbzjOLHEbxw9jAhq7WC1FvovkOpT+jdP 2LG74G9dJ2ZhhMhHzqXZQUhGnMWcxkNxrR7IA6TBkkte2oRKLJtVZma4qKvNuKTfudagSmw5z uF0LB3UVAKRacg7XvIUGCI4Y98TjFm5W+/gKnT9No3DWp5XU1Nk5EDjNx0TorP1MEr34rZ4ZR y+jYOWPTWn86Ak+/WdXUDFk/9Mb3b35IsQRU+elKO+sccbwylqMoUueKUHwHM6TJdvu2J4RWe 4JX7vw7zHDuiosrwpC2ddTKZpHeIjivK4yz1vkZPSevndCRFrX4F9Oy6Mn+CCQy3Yybt8x9Qb yu4n1LQVyZPyuwHghgv1oQOCYY5Ybg09NAuh5aawtzZNzSq1GpZYtZt9numQJG+GEu0fa2ZwO 6DNP46Lc3uAWDyafku5Z9S8bWCN1jb5Q7raMwQm+UX4dVOx5wQ= Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 12:10:39 -0000 Hi Jonathan, > On Mar 6, 2018, at 12:46, Jonathan Morton = wrote: >=20 >> On 6 Mar, 2018, at 1:17 pm, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>=20 >>> So far it looks like everything is working fine and behaving as it >>> should (on a plain Ethernet interface). The one wrinkle is that it >>> takes a few thousand packets for the avg_off value to converge on = the >>> true value, but that should easily be tolerable in most cases. >>=20 >> So, erm, what do the new stats mean? ;) >=20 > avg_off: the average observed offset of the transport header in = packets. This should converge to 14 on Ethernet. >=20 > max/min_tran: tracking the transport-layer size of packets; max_tran =3D= max_len-avg_off if GSO is off. >=20 > max/min_adj: tracking the overhead-adjusted size of packets; these = should be the adjusted sizes of the corresponding transport-layer sizes, = so can be used to check the calculations. >=20 > It's probably feasible to lay these out better in the output, so they = take up fewer lines on screen. Great this matches what I deduced from the numbers. I note that by = replacing a cake instance with itself (so not changing the = configuration) will reset the counters. Question: am I right to assume that the _adj values are what you pass in = as the true packet size into cake's calculation? I really like these outputs so far (running flent I saw: qdisc cake 8003: dev eth0 root refcnt 6 unlimited diffserv3 = triple-isolate rtt 100.0ms noatm overhead 34 mpu 64=20 Sent 269164303 bytes 611190 pkt (dropped 0, overlimits 0 requeues 2)=20 backlog 0b 0p requeues 2=20 memory used: 10880b of 15140Kb capacity estimate: 0bit Bulk Best Effort Voice thresh 0bit 0bit 0bit target 5.0ms 5.0ms 5.0ms interval 100.0ms 100.0ms 100.0ms pk_delay 14us 11us 8us av_delay 2us 2us 1us sp_delay 0us 0us 0us pkts 61400 395326 154464 bytes 17617151 183250552 68296600 way_inds 0 0 0 way_miss 3 89 11 way_cols 0 0 0 drops 0 0 0 marks 0 0 0 ack_drop 0 0 0 sp_flows 2 13 7 bk_flows 0 0 0 un_flows 0 0 0 max_len 3012 3028 3012 max_tran 1492 max_adj 1526 min_tran 28 min_adj 64 avg_off 14 Which is pretty much what I expected (speedtest ran over an effective = MTU1492 PPPoE link*), but I still want to make more in-depth tests. Now = we just need to carry this nto lede to get more testers. Plus it might = make sense to merge tc-adv with iproute2-cake-next so that we have one = master repository for the tc changes as well. I believe that before the = xstats and Jonathan's recent updates iproute2-cake-next was more up to = date, but I am probably wrong... Best Regards Sebastian *) Interestingly takling stats later revealed: qdisc cake 8003: dev eth0 root refcnt 6 unlimited diffserv3 = triple-isolate rtt 100.0ms noatm overhead 34 mpu 64=20 Sent 743833445 bytes 1965042 pkt (dropped 0, overlimits 0 requeues 6)=20= backlog 0b 0p requeues 6=20 memory used: 16346b of 15140Kb capacity estimate: 0bit Bulk Best Effort Voice thresh 0bit 0bit 0bit target 5.0ms 5.0ms 5.0ms interval 100.0ms 100.0ms 100.0ms pk_delay 8us 12us 9us av_delay 1us 3us 3us sp_delay 1us 1us 1us pkts 167869 1382188 414985 bytes 49022886 511662935 183147624 way_inds 0 341 0 way_miss 6 1137 20 way_cols 0 0 0 drops 0 0 0 marks 0 0 0 ack_drop 0 0 0 sp_flows 1 1 0 bk_flows 0 0 1 un_flows 0 0 0 max_len 3012 3028 3012 max_tran 1500 max_adj 1534 min_tran 28 min_adj 64 avg_off 14 Son between this sample and the speedtest the host exchanged MTU1500 = packets with the local network... >=20 > - Jonathan Morton >=20