From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 644B73B29E for ; Fri, 28 Dec 2018 17:07:21 -0500 (EST) Received: by mail-lj1-x22a.google.com with SMTP id x85-v6so19710296ljb.2 for ; Fri, 28 Dec 2018 14:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2mz6ahkl2GO1YvcETRB4dm+ab2HBhxDRxFKF7SL70lA=; b=qUluazrkNDGT1y0rCFlUzpaErWQ2VIoUyZdLRtHsw5exzU73t9pndc4JTKEzCaPNln OcCx58EqrNJ8elqOshcMf4EPzFcrhWUcF8Hp6AWyrF35tqTwOV/A07siW4f7EuUT+IiV Nr9IMWLRhNuizKLgG7+xue0xCPqQpeIXRd+cLaro7u9TH4gmKt/ysSSizpcbpgWB5rWq iO1W1SAuoUc1/Z0Y131UdAemERnHtNRtDQwbtUzxgxXXBNcFgZQnEcf+ZkdkZ+lhKMn7 jFAKLuJWQicuj71Gq+AjvRH2i/N7Nd1RMwH2Ti3XxxzYgafA7ARlCtGn03/i7zwmeRV3 Jviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2mz6ahkl2GO1YvcETRB4dm+ab2HBhxDRxFKF7SL70lA=; b=OZb+zuK4OH95qaGHO1cpjF8mAWe4JQaqTVoIgYqqjjumRPY4pluRmXxqJkAeJ/DGDe o89TP08TKMDmil3g2uvKf4PGTauCp6E8UALL3YPVN5zxvk/iKxyWaGI9vl7xlattlf6q /OxjcJ/WWL+vVy/+eT6UvzwMa+p8ddUZpBh8rBm6iTsi1GuAGnLz7JGfsayXVeWoZAst it2gCrab9nWd1qNRtfy31YPfXi67/rRN1m1TN6sf4ezGYzrMCGyDc0NA85suQJOE01Xg s3ncxxwuv4jmnhmYTuRrExGBHHd6nXFXTtueNBwTNQ0FnxKoMZdWm0QvWf7CbLBpahMf iRDw== X-Gm-Message-State: AJcUukfxS69jUigrYbMEoEiYM2zsTEmiAFGLDkY/HtmuWgtjxYEOFrFJ Ocqxj8tPldYU++aP5grxBl2OgBq5 X-Google-Smtp-Source: ALg8bN7QHw/8HfzakMcZaBOzXVcFupjGzvojTu3tXQwZseemvZy7h6iXfJL1hP48EVQ/TWfmCKTFrg== X-Received: by 2002:a2e:8719:: with SMTP id m25-v6mr18384898lji.121.1546034839906; Fri, 28 Dec 2018 14:07:19 -0800 (PST) Received: from jonathartonsmbp.lan (83-245-237-64-nat-p.elisa-mobile.fi. [83.245.237.64]) by smtp.gmail.com with ESMTPSA id q128-v6sm3405501ljq.14.2018.12.28.14.07.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Dec 2018 14:07:19 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: <5482A3CA-9C36-4DDE-A858-24D8467F70C7@heistp.net> Date: Sat, 29 Dec 2018 00:07:17 +0200 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <5482A3CA-9C36-4DDE-A858-24D8467F70C7@heistp.net> To: Pete Heist X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 22:07:21 -0000 > On 28 Dec, 2018, at 11:22 pm, Pete Heist wrote: >=20 > This smells of a bug Toke fixed on Sep 12, 2018 in = 42e87f12ea5c390bf5eeb658c942bc810046160a, but then reverted in the next = commit because it was fixed upstream. However, if I re-apply that = commit, it still doesn=E2=80=99t fix it. >=20 > Perhaps there are more cases where skb_reset_mac_len(skb) needs to be = called somewhere for VLAN support? I did wonder if there was something about the old kernel messing things = up. Do you still get acceptable throughput if you disable GRO/GSO at the = interfaces? - Jonathan Morton