From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <moeller0@gmx.de>
Received: from mout.gmx.net (mout.gmx.net [212.227.17.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mout.gmx.net",
	Issuer "TeleSec ServerPass DE-1" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 750F621F2E0
	for <cake@lists.bufferbloat.net>; Tue, 14 Apr 2015 00:03:26 -0700 (PDT)
Received: from hms-beagle.lan ([134.2.89.70]) by mail.gmx.com (mrgmx102) with
	ESMTPSA (Nemesis) id 0MQdAP-1Ynii10t2L-00TzHy;
	Tue, 14 Apr 2015 09:03:24 +0200
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Sebastian Moeller <moeller0@gmx.de>
In-Reply-To: <46A45ED1-9CB9-4F22-BAA6-9B95A2F0F6CD@gmail.com>
Date: Tue, 14 Apr 2015 09:03:21 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <A4FA34F4-807E-463B-BF86-96036F3C3B00@gmx.de>
References: <EFD9024A-2241-4271-A767-270A41703A5D@gmx.de>
	<CAA93jw5eRMNAwba7UphtWrpH1hT_aKM9eDhATNAL3AV9-9iE4g@mail.gmail.com>
	<621729A8-E1F6-4AAD-AA99-C5B84B46E034@gmx.de>
	<90F78D21-4FE5-46F6-B96D-2E00FB373E71@gmail.com>
	<D4159197-AFF0-410A-B242-BAB7742CD923@gmx.de>
	<A8F84EFD-1CFE-4D70-A5CB-3153D70B3441@gmail.com>
	<9FCA693C-840F-409C-A49B-322F6FA54712@gmx.de>
	<46A45ED1-9CB9-4F22-BAA6-9B95A2F0F6CD@gmail.com>
To: Jonathan Morton <chromatix99@gmail.com>
X-Mailer: Apple Mail (2.1878.6)
X-Provags-ID: V03:K0:K/qtduIPn90BYbvL3drmHb6AEipSvMuoahQ7hKsTX18pEatF/sU
	D+Cxlf/2RdjsAMqnL0XoVUvfABEk1iTu83+oILyIiqocEpoTSBuajBFFglbN8oeKrGYKKbT
	KXBpbXei35c+8M2STMXcngRwrNKyppqu4X51TfkfQyJ45W3fy6ZjjMUkv4etkFCQbIBEyua
	sTnqTNHMzI3bVjdLowUDA==
X-UI-Out-Filterresults: notjunk:1;
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] #17
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2015 07:03:56 -0000

Hi Jonathan,

On Apr 14, 2015, at 02:58 , Jonathan Morton <chromatix99@gmail.com> =
wrote:

>=20
>> On 13 Apr, 2015, at 23:10, Sebastian Moeller <moeller0@gmx.de> wrote:
>>=20
>> Does your method also work with the same encapsulations as =
skb_flow_dissect?
>=20
> I=92m not sure.  Given the complexity, it=92s probably neither a =
strict superset or subset; it=92s also fairly likely that the outermost =
DSCP is returned from a tunnelled IP scenario.  ISTR that tunnels are =
supposed to copy the TOS byte on entry and the ECN field on exit, though =
there are almost certainly tunnel implementations which don=92t do that.

	Fair enough, I was actually just thinking about PPPoE and =
VLAN/double VLAN tags, both of which change the offset of the TOS bits =
(as well as the offset difference for IPv4 and IPv6), so it seems a bit =
of a hassle handling down the encapsulation twice (once for the TOS bits =
and once for the flow hash). Most likely I am biased due to the =
computational cost of doing this with a naive set of tc filters ;) I =
guess.

Best Regards
	Sebastian

>=20
> - Jonathan Morton
>=20