From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9BBF53CB41 for ; Tue, 6 Mar 2018 08:18:10 -0500 (EST) Received: from [192.168.250.102] ([134.76.241.253]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MF5C3-1ev9Uh0eAl-00GEsS; Tue, 06 Mar 2018 14:18:08 +0100 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Sebastian Moeller In-Reply-To: Date: Tue, 6 Mar 2018 14:18:06 +0100 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <12C7E818-E440-40A9-AE67-C6EDD7F87FB6@gmx.de> <08E2549E-769F-4AF3-8D34-22A149432463@gmail.com> <87ina91mir.fsf@toke.dk> To: Jonathan Morton X-Mailer: Apple Mail (2.3445.5.20) X-Provags-ID: V03:K0:5wul3SRD4skPQcGKaoNh743oSkHwXq6keQTiBbJkEWXItNq7Aih w0GVFNOBMdYipgFc+jLocavydP/CN7IY4FVj34wey3mr9ojSyePGnCn+w277Gy8FT6qVPJE KNLRX3GKQDPGUEpt/BfmFaODMVbMMIuF4LlTgPxJc5cb4q9sOMsFuI/wknKWcEPLwPR/xbt inN/U1TAYIPCAviyyEoOg== X-UI-Out-Filterresults: notjunk:1;V01:K0:FPneFbWB1l0=:Fxc4r0MCO7PDUwe87L++aD 9VNp/X1LT5XzvDe1uFSoeZbdDs1VmIqa+H3q20AlaRWq8Ff+FnZFRszT8JrYha981V775kAK2 5gXEgT4dAu17YKkbbJ3IFYWuXYCOMM8lte0v/UykkkDakt3sudrUNt1gSgl8Orbl5TVVvcAVX 2BvBrilUhGNsBuha085Nx9CQAAAOYuEYf3PPXX6gD37LttIsckQHcRe0RULrAWeJv0rw13akw mdDj50oMcoHwqjrJdEYtfPqTu7Z74nP84RFqQRHGFRASQZcfSz6wIo1y8w2HyuNKplqLlOXa5 3FXxYfiXKwpMgbK6iK6oebzLyybYfImpUaDQLuJVBswHSpkNb3amrtP0inijL3I4Ji3BVVQBl KxGm0Vi2HFSjPGunn0GrD+4WXHtPKjjzpOyJrwupK0sYHkKTxFPWJiO/8UVaSFp3jWRsYtEAz Crcwj5HeT0nQFdPSEz0VvXXZIHBlh7pVD/c6LTjgCjZ8wz4lPAXR7mlmSLKuDMYDKT17qeGif DQghJmCXVrJvWO9BBU8GG4NBJGVDY+4i1a2KHlJwuIY8RN3N54yQlxD9fD6iA0IjJYrJ8QS4E pz4kISR2bukB33+sHBOxUMQnSv9lzH9lMxOlR5TGPSTNGj5gpoSouzc39CqAy4l3osf8xoHZw yX28FpGw1MP8hZPA33mkI4Q6rt7QNguOg00C5FUFUmjFMfXDIAADnik5S5wdndVeclfT/p/j5 fzlkri2gsPxMm0vHYC3mH0MDCKPEkbtnx8FxkG3XasPPi9rr++Wafvy1Qn/WiRSDSjFvLZZcm yfP9pIpoEm3EiNFbZr1iCDcBV066Y2dHmtlOnUYy5rnMj6Gfe4= Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 13:18:11 -0000 Hi Jonathan, > On Mar 6, 2018, at 14:08, Jonathan Morton = wrote: >=20 >> On 6 Mar, 2018, at 2:10 pm, Sebastian Moeller = wrote: >>=20 >> Question: am I right to assume that the _adj values are what you pass = in as the true packet size into cake's calculation? >=20 > Yes, exactly. They include ATM, PTM and MPU factors when relevant. Excellent, this is basically the information we would also see when tc = stab is used, and being the actually input in the (maybe indirect) = transfer time calculations is the best number IMHO for sanity = checking...=20 >=20 >> I believe that before the xstats and Jonathan's recent updates = iproute2-cake-next was more up to date, but I am probably wrong... >=20 > I understand it's based on a newer version of iproute2, so would be = easier to merge upstream, but its Cake support was exactly equivalent. = The latest batch of changes should be straightforward to port forward to = it. Again, that sounds great, in your opinion now with the = overhead/size accounting put on new footing and Toke's xstats work are = we closer to being mergeable upstream? Any other blockers pending = improvements? Best Regards Sebastian >=20 > - Jonathan Morton >=20