Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Pete Heist <pete@heistp.net>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Dave Taht" <dave.taht@gmail.com>,
	"Cake List" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [bpf-next RFC 2/3] flow_dissector: implements eBPF parser
Date: Wed, 22 Aug 2018 21:18:15 +0200	[thread overview]
Message-ID: <AA80BAFF-11FC-4330-BE8B-6004188FEB3C@heistp.net> (raw)
In-Reply-To: <72d4eaa7-e1ae-67c9-98fa-2664d1cd52f9@iogearbox.net>


> On Aug 22, 2018, at 12:41 PM, Daniel Borkmann <daniel@iogearbox.net> wrote:
> 
> On 08/22/2018 11:25 AM, Toke Høiland-Jørgensen wrote:
>> Pete Heist <pete@heistp.net> writes:
>> 
>> Well, it operates on the byte code and errs on the side of safety. I.e.,
>> if it can't prove your program is safe it is going to reject it. Which
>> can be less than helpful.
>> 
>> There's a mode where it can dump its state including the byte code it is
>> operating at, which can be helpful in figuring out why you get an error.
>> But it has a way to go yet compared with regular compiler error
>> messages... :)
> 
> There's also llvm-objdump which can dump with annotated BPF C code and
> it allows to match the verifier output line number with it. There's a
> small example in the doc under LLVM section on how to get there:
> 
> https://cilium.readthedocs.io/en/latest/bpf/#llvm

Thank you Daniel, that helped match the C source with the verifier output- much easier.

I’m still not sure why I was able to fix my problem by simply returning my uint16_t classid through the stack rather than setting it through a passed in pointer, but nevertheless, that works. :)

Pete


      parent reply	other threads:[~2018-08-22 19:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180816164423.14368-1-peterpenkov96@gmail.com>
     [not found] ` <20180816164423.14368-3-peterpenkov96@gmail.com>
2018-08-18 17:19   ` [Cake] Fwd: " Dave Taht
2018-08-22  9:16     ` [Cake] " Pete Heist
2018-08-22  9:25       ` Toke Høiland-Jørgensen
2018-08-22  9:37         ` Pete Heist
2018-08-22 10:41         ` Daniel Borkmann
2018-08-22 16:50           ` Dave Taht
2018-08-22 19:18           ` Pete Heist [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AA80BAFF-11FC-4330-BE8B-6004188FEB3C@heistp.net \
    --to=pete@heistp.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=daniel@iogearbox.net \
    --cc=dave.taht@gmail.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox