From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <chromatix99@gmail.com>
Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com
	[IPv6:2a00:1450:4010:c07::233])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority G2" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 48ACC21F547
	for <cake@lists.bufferbloat.net>; Tue,  3 Nov 2015 09:31:04 -0800 (PST)
Received: by lfbn126 with SMTP id n126so26455714lfb.2
	for <cake@lists.bufferbloat.net>; Tue, 03 Nov 2015 09:31:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=content-type:mime-version:subject:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to;
	bh=+HvVdz+NuyYxEFvH+afqhQUSA6br22FhOYhF3C5Jw6Y=;
	b=rTMEjtniLdZ3NYSC0WRsnBEnxbYVDtnRrGfu2OFpOORakzb6PiAvPuNyUOb2nIlSZ8
	njA7vBrMSMlSz/SescHe6S33LxUTlkL3WKzKZ98xa+ttsjCQOgCt4+upChPiGTa6hamV
	9LfQUDP9sBn+HOWLtmxGSqtfrbW4/EhX51/eJcq4Lqb/lURkijeOSfzajjui9LHoTpkc
	5sJ+AJQUy/RXQ1hyJs9sbCz7u2SFWpzMiS8bXjRTFLJPLdAMjNL4H5N6QFrSe2EiVKxO
	+FR/BXZSwwk/ZMzWwTeLnfLAGOC6jPaNlaeY5sENsr4ehgbE5+5jQAzhmxZSszhYibiq
	AptA==
X-Received: by 10.112.17.70 with SMTP id m6mr4740520lbd.76.1446571863008;
	Tue, 03 Nov 2015 09:31:03 -0800 (PST)
Received: from bass.home.chromatix.fi (83-245-237-115-nat-p.elisa-mobile.fi.
	[83.245.237.115]) by smtp.gmail.com with ESMTPSA id
	zc3sm4189808lbb.38.2015.11.03.09.31.02
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Tue, 03 Nov 2015 09:31:02 -0800 (PST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
From: Jonathan Morton <chromatix99@gmail.com>
In-Reply-To: <87si4natbf.fsf@toke.dk>
Date: Tue, 3 Nov 2015 19:31:00 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <AE11FF8D-97A7-4145-981D-2201C7A719DE@gmail.com>
References: <87pozspckj.fsf@toke.dk>
	<6A2609D9-7747-487B-9484-ECC69C50DE96@gmx.de>
	<CA077244-F5B4-4748-954B-9618BACAC90F@gmail.com>
	<874mh3pai9.fsf@toke.dk>
	<50C2A7B7-1B81-41E1-B534-CA449296FE77@gmail.com>
	<87a8qvc8tz.fsf@toke.dk>
	<328DEF4F-F149-42C5-920E-53D16DCF544C@gmx.de>
	<87si4natbf.fsf@toke.dk>
To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
X-Mailer: Apple Mail (2.3096.5)
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Long-RTT broken again
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2015 17:31:27 -0000


> On 3 Nov, 2015, at 19:25, Toke H=C3=B8iland-J=C3=B8rgensen =
<toke@toke.dk> wrote:
>=20
> 	if (likely(sch->qstats.backlog + qdisc_pkt_len(skb) <=3D =
sch->limit))
> 		return qdisc_enqueue_tail(skb, sch);
>=20
> on enqueue.
>=20
> Which is the same data that Cake uses. Hmm, weird=E2=80=A6

No, Cake uses skb->truesize for this particular purpose.  It uses =
qdisc_pkt_len(skb) only for timing purposes.

 - Jonathan Morton