From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 438553CB35 for ; Sun, 3 Mar 2019 14:49:04 -0500 (EST) Received: by mail-wr1-x42d.google.com with SMTP id t18so3255361wrx.2 for ; Sun, 03 Mar 2019 11:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2Tr4wak5UKzswfhg264pAVl1qVrwZYkA7eZRHKac2zU=; b=Jw4eVyCv0Tq+n5+UcrP9wrliLwiEY6zDeBfxN7+D6UxqFu+VaP4Bd/fL8U6LNNTxV7 fKjC+yjGX+s7wNao0RAhPOvRlo61qedoYo9PSS07x3DJEEd1ZfwNKKFn5Ergmg2RGrdA fg8JomvmG+J0JtcuZoMzx5ctF0CpiBXpaqR/dPVOX2R+03YdsQJ26Uh97hgh4zdB1Ymp TzSyAYmem3BgRHdHbZewO3Ntft16UJ5MGXQmj9F4byooTmhfKMsBFTbOtHCkX33oJPSs j3r6QrJwYojDkdSy0GH9vjQFJWs/IGslpyeTheR3iTzYVOpfTORyPhxZeks6gxweIXHu bFVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2Tr4wak5UKzswfhg264pAVl1qVrwZYkA7eZRHKac2zU=; b=Qyykf25AGr5SEIJ2LZietivE+Kiyd/Lh132dw2VMOGTybMUWDhIYVzpRGzTS/t3BYG +/oRdCkSm8kswsKLxANSs3Cp8ddaD0yYgIx8t0BdRihq0pnar76E/fwuEc5uFYlWhXD2 pRG1ZEELtJ0/bK1qqKz1MP1Z/2r/RCf2pfW5W1CWQWFbZzS//j7aDq1guhOXCCQlAPMQ gItdZTkA0QqzHfJf8teysgOYRpAjF8UNwE3rJyMAPeH3Pw85sdP/2MJjp66wjqivjCLw KYTDyWLJcM/7W87UMR5WsXHy5WqsfJHDxU3gtp8z1e+zIVMbhubqIGKoiJMQbk+bv8ME PMdw== X-Gm-Message-State: APjAAAUGXEQa7a5nOXrg9Fmdl0MhfaMeL53z/VL9NlBWaEb0ejhhdFKH U5j/1YXqbKMHfnpSFaWx5n8Gtw== X-Google-Smtp-Source: APXvYqw9RsAls1QlYhv4aaszeZep1icXrROfIG5WYagzjGb44R3Nbwl1j6rKAM1SuA1KkVkpNWOWpQ== X-Received: by 2002:a5d:6785:: with SMTP id v5mr11160184wru.59.1551642543419; Sun, 03 Mar 2019 11:49:03 -0800 (PST) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id z10sm3100218wml.39.2019.03.03.11.49.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Mar 2019 11:49:02 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Pete Heist In-Reply-To: <000001d4d1f3$c5599eb0$500cdc10$@gmail.com> Date: Sun, 3 Mar 2019 20:49:01 +0100 Cc: Jonathan Morton , Sebastian Moeller , =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen_via_Cake?= Content-Transfer-Encoding: quoted-printable Message-Id: References: <72193310-7502-47B8-9554-7F8F9FA23204@heistp.net> <874l8mn9iy.fsf@toke.dk> <417E17B2-17F7-4106-A92D-C5B5AC41D808@gmx.de> <5CC769AC-AD0C-40E8-BFCA-6AD2A8162FFC@gmail.com> <49A8FB42-EC0B-41B7-8CE4-888DF3C2A88D@gmx.de> <542D3BC3-317A-4F3E-A5B6-16FF678DDFAC@gmail.com> <5C8177FD-2605-4CDD-9AA2-F0E5AF9C779B@heistp.net> <1C81557C-2FD5-4C48-BC17-F9E841D08097@gmail.com> <511C22FF-64A5-46CA-BFB9-4EA350B76122@gmail.com> <9746402E-41EA-43F9-AAE6-53C038EABFFF@heistp.net> <000001d4d1f3$c5599eb0$500cdc10$@gmail.com> To: gamanakis@gmail.com X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] Upstream submission of dual-mode fairness patch X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 19:49:04 -0000 > On Mar 3, 2019, at 8:03 PM, gamanakis@gmail.com wrote: >=20 > For the record, I can replicate it now. I also think that this = behavior is expected. > There is a work-around but it seems like an awful hack: >=20 > ----------8<---------- > diff --git a/sch_cake.c b/sch_cake.c > index 733b897..08e08f4 100644 > --- a/sch_cake.c > +++ b/sch_cake.c > @@ -2216,7 +2216,6 @@ retry: > if (q->rate_flags & CAKE_FLAG_INGRESS) { > len =3D cake_advance_shaper(q, b, skb, > now, true); > - flow->deficit -=3D len; > b->tin_deficit -=3D len; > } > flow->dropped++; > ----------8<---------- >=20 >=20 > Then the results are: >=20 > IP1, 1 up: 47.18 mbit/s > IP2, 32 up: 46.99 > IP1, 32 down: 40.98 > IP2, 1 down: 41.34 Yes, thanks for confirming it, this fix equalizes goodput for me as = well, although I think we=E2=80=99re in agreement that nothing should = actually change in the end(?) If so, I think we should document this. If it wasn=E2=80=99t obvious to = us right away what was happening, then it probably won=E2=80=99t be = obvious to others. If I don=E2=80=99t hear any objection to this in the next couple days, = I=E2=80=99ll submit a pull request to tc-adv for tc-cake.8, if that=E2=80=99= s the right place to do it.