From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 694203B2A4 for ; Sat, 5 Jan 2019 07:51:11 -0500 (EST) Received: by mail-wr1-x441.google.com with SMTP id v13so38815661wrw.5 for ; Sat, 05 Jan 2019 04:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=azpYMp1YiVe9sW1PR4hpoJInO6cKDVoTOpZCmrNfgdA=; b=VMyS3QnrwRJd0fha9GyAFClRoUuZUlh9mGdidq7TFD7rkbh3CpZBAZPHPbx/oP3LF5 zqwCgcsaTn61R/RCNzqeeNNJ9gMHmB0F1r4BKxyZs/ZBYo1H73bac6S5VbBbkqWhxb4F z8H/lCz6LBAv5HfF8K3dG1xV/uflgebdoFBU6aXiGIAXj9AE6r5hJkbhgnlXMyRD8uUt w/LpEdcNEGerSp6OwLEv2WXAjZUFe20ImvprdhTc7Yep5333oAXebRmSvvAIJAqi9Uqs 2GGTtgA3N9g+pcRNS1Amn1QaaCOVYE/mKYig1TcO6aVrMOBMHqnSE+mpfeospV76+yTS iPyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=azpYMp1YiVe9sW1PR4hpoJInO6cKDVoTOpZCmrNfgdA=; b=JliZVb+pJ/sy44g9CFRt/F+kcpk9Y14QDJMDuzYKdVf9VSDNp/8l2qYMxQ4zZZSaPV s9Ie8oKU0YJ78oTTIUqV6lpzkvchzve727TGtF600VQFSrYLYRdIBs7SNGd+umjjdRZO jlCGrADyQRw/GYUs2HNyOH41fo0dnr1EZIUWW6gn19zDq4KJV40Hrj8qJ4+xzuFeyGCn VkRe0sy/EOx25l3WCTgyIBPxgq3flxxcBS0ObJC7+V00MrSrO8Eibfl5h67BIp3S7II4 VFkrFPM4jQKnuMONt1fEV8EgFluuY+HqzZm6Tw3KQ79slQshljds/v61QQQCzuMlo9+0 A2vw== X-Gm-Message-State: AJcUukeqMGdHczbbT/O2tYSIPxU3MEHIges4v6/WVEPTELG1fZ17p7JW aFHGFGB9OhpkXhjiSgMhGxf7f2gwyn0= X-Google-Smtp-Source: ALg8bN4wSMd8Bf02Wgm7RfJAwUDoIA0l1mzsirmQ87FRkmFuaJnSalKJ1zLFHertRBWLJZXOMRa+Aw== X-Received: by 2002:a5d:5443:: with SMTP id w3mr43695415wrv.4.1546692670392; Sat, 05 Jan 2019 04:51:10 -0800 (PST) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id p139sm6346443wmd.31.2019.01.05.04.51.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jan 2019 04:51:09 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Pete Heist In-Reply-To: <87tvinxos7.fsf@toke.dk> Date: Sat, 5 Jan 2019 13:51:08 +0100 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <5482A3CA-9C36-4DDE-A858-24D8467F70C7@heistp.net> <8736q8yumt.fsf@toke.dk> <4C422792-7E51-4DBA-A229-FA7D3F987FB6@heistp.net> <87zhsgxdao.fsf@toke.dk> <87wonjxvss.fsf@toke.dk> <0077CC34-490F-4D76-82D3-BE37B27F2E1C@heistp.net> <49A6DCF8-BE98-47F4-9C66-6B4288390A58@heistp.net> <87tvinxos7.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2019 12:51:11 -0000 Ok, that fixes the compiler warnings, but I get this now. Same as before = it=E2=80=99s repeated until reboot, stack sometimes changes but I always = see sch_hfsc.c:1427 at the beginning: root@apu1a:~# [ 5972.967008] ------------[ cut here ]------------ [ 5972.971707] WARNING: CPU: 1 PID: 0 at net/sched/sch_hfsc.c:1427 = 0xfa02f4ef() [ 5972.978812] Modules linked in: sch_cake(O) em_meta cls_basic sch_hfsc = xt_ACCOUNT(O) ipt_REJECT xt_recent iptable_mangle iptable_nat nf] [ 5973.032173] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G O = 3.16.7-ckt9-voyage #1 [ 5973.040181] Hardware name: PC Engines APU/APU, BIOS 4.0 09/08/2014 [ 5973.046368] 00000000 00000000 f5c99d94 c13167e9 00000000 f5c99dac = c102a7dd fa02f4ef [ 5973.054323] f06b6c00 00000000 00000000 f5c99dbc c102a803 00000009 = 00000000 f5c99ddc [ 5973.062279] fa02f4ef f06b6fc8 b48b3e3f 00000015 f06b6c00 00000000 = 00000040 f5c99df8 [ 5973.070226] Call Trace: [ 5973.072703] [] dump_stack+0x41/0x52 [ 5973.077160] [] warn_slowpath_common+0x5c/0x73 [ 5973.082485] [] ? 0xfa02f4ee [ 5973.086249] [] warn_slowpath_null+0xf/0x13 [ 5973.091308] [] 0xfa02f4ee [ 5973.094899] [] __qdisc_run+0x81/0xf0 [ 5973.099441] [] __dev_queue_xmit+0x23d/0x35f [ 5973.104594] [] dev_queue_xmit+0xa/0xc [ 5973.109224] [] ip_finish_output+0x345/0x73d [ 5973.114372] [] ip_output+0x73/0xaf [ 5973.118741] [] ip_forward_finish+0x66/0x6b [ 5973.123801] [] ip_forward+0x2b0/0x36d [ 5973.128429] [] ip_rcv_finish+0x267/0x29a [ 5973.133317] [] ip_rcv+0x2b4/0x338 [ 5973.137601] [] __netif_receive_skb_core+0x467/0x4b6 [ 5973.143450] [] __netif_receive_skb+0x48/0x59 [ 5973.148693] [] netif_receive_skb_internal+0x59/0x85 [ 5973.154533] [] napi_gro_complete+0x87/0x8c [ 5973.159594] [] napi_gro_flush+0x3e/0x53 [ 5973.164395] [] napi_complete+0x17/0x27 [ 5973.169114] [] 0xf80841a2 [ 5973.172709] [] net_rx_action+0x56/0x10e [ 5973.177517] [] __do_softirq+0x91/0x175 [ 5973.182233] [] ? __hrtimer_tasklet_trampoline+0x1a/0x1a [ 5973.188421] [] do_softirq_own_stack+0x1d/0x23 [ 5973.193744] [] irq_exit+0x34/0x75 [ 5973.198679] [] do_IRQ+0x92/0xa6 [ 5973.202789] [] common_interrupt+0x2c/0x40 [ 5973.207765] [] ? cpuidle_enter_state+0x37/0x96 [ 5973.213179] [] cpuidle_enter+0xf/0x12 [ 5973.217810] [] cpu_startup_entry+0x135/0x1e1 [ 5973.223053] [] start_secondary+0x1a6/0x1ab [ 5973.228111] ---[ end trace fe3dc3fad8d2493c ]--- > On Jan 5, 2019, at 1:38 PM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Pete Heist writes: >=20 >> Quick update to the trace because I had to apply the patch manually >> and missed one line to remove (qdisc_tree_reduce_backlog...), just so >> it doesn=E2=80=99t through off the addresses for you, but it still = does the >> same thing: >=20 > Ah, my bad; you need to replace >=20 > qdisc_match_from_root(qdisc_dev(sch), TC_H_MAJ(parentid)); >=20 > with >=20 > qdisc_match_from_root(qdisc_dev(sch)->qdisc, TC_H_MAJ(parentid)); >=20 > -Toke