From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3CF9C3B2A4 for ; Fri, 6 Jul 2018 09:23:35 -0400 (EDT) Received: by mail-lf0-x22e.google.com with SMTP id h7-v6so9799037lfc.11 for ; Fri, 06 Jul 2018 06:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zkZWfYShqswBLWdcmZhHcfRerWVwXXBLqLNoE8gt9XU=; b=a3UVo9sGyeJ7RThQ0yuayPnq9AamK9Jifn31V5qdKOtnvr81PdOg3qPyslyVWYaGJ+ G9qx+RCYbzsqwrJkKDxI29DUkCIQlIfVry2F2sdwEHsB3bYEOvbxlwwhvwIwfBwH2e2L 1TKeUvtEqqTBFwY8XCpT0R/uUUD+zcbNgqTjB2UQdPtzImyZ7mxFwveBCV0OPbkZPuxK oIwc2I6qh8mwR1xj45w+ZlUy6hC8EqBrp0/1Otpcfpdq9GR6DDiEaeRiwXtbUAaKUg41 99QunOI+j3tPEqEcBDsKjAdTIeDkUD8R2Qv5XndZU0frjhcAKRjmNi/8fGnE/qp8urkE PhNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zkZWfYShqswBLWdcmZhHcfRerWVwXXBLqLNoE8gt9XU=; b=pRtu6pdW36CmL0ZaYyqYIwtQos5WC3TejvSeDRVdrquz6LR5qXwd+ibkFWzEAkLw5q crtwRNoTnvjjI/t04PzrxJjXiWPn8Mdbod9QUDifZeSuTzlAWikiCTAZunW1MLQNdMVC jymgFM3N66yQGMgfjtKXiSvzGb3T/ymFMUnWxaIWMEBOOB7fBiFObrif08/PNdYbDw2K xsdtW3snhU5nkdLG3FNb6SRGo9e4tEmKe1ftJ5f+6ErELN09To/cyF1w5bjsfda67/AP A491wQZezv2Q/RDKxNAn1aqhB375PrZUD6w0joiOs1k96AGb6ygjMVBuEeJPeaqCEsSY n5Dg== X-Gm-Message-State: APt69E1tGw/Bh4eV0d0JRbiUOZZS1TtvhRC2wVB5qSLOq0ylvJhKQh6M mJhKk+mJ7e3SD49bOh3P2L8= X-Google-Smtp-Source: AAOMgpfC+7Yb8pQvQw0qD/NnJiqlw6GXXuzSRDkvnHj0Fat3sIQbExHOlaIF1FI6ihMRjgi4gGaGJQ== X-Received: by 2002:a19:138b:: with SMTP id 11-v6mr7696248lft.74.1530883413928; Fri, 06 Jul 2018 06:23:33 -0700 (PDT) Received: from [192.168.239.216] (83-245-233-230-nat-p.elisa-mobile.fi. [83.245.233.230]) by smtp.gmail.com with ESMTPSA id o3-v6sm1468091lfc.95.2018.07.06.06.23.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 06:23:33 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) From: Jonathan Morton In-Reply-To: <874lhcbiux.fsf@toke.dk> Date: Fri, 6 Jul 2018 16:23:32 +0300 Cc: cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180706115745.2791-1-toke@toke.dk> <87a7r4bmlk.fsf@toke.dk> <874lhcbiux.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.8.2) Subject: Re: [Cake] [PATCH] Keep an internal counter for total queue length X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 13:23:35 -0000 > On 6 Jul, 2018, at 4:21 pm, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 >> I'm handling it without using any extra permanent state, just making >> use of what's already there. Take a look at latest commit. >=20 > Yup, that also fixes the infinite loop issue. I'm fine with doing it > this way; however, it doesn't handle the other places where we check > whether sch->q.qlen is nonzero. Are you sure that is not going to give > us more problems down the road? :) The other places are checking whether the queue is empty for the = purposes of updating the shaper state. They are therefore much less = critical, and I think self-correcting. - Jonathan Morton