From: Pete Heist <pete@heistp.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router
Date: Sat, 5 Jan 2019 06:58:03 +0100 [thread overview]
Message-ID: <B1F84884-7150-41BB-9E39-640F560F99D5@heistp.net> (raw)
In-Reply-To: <87zhsgxdao.fsf@toke.dk>
> On Jan 4, 2019, at 11:34 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> Pete Heist <pete@heistp.net> writes:
>
> This basically means that we can't use CAKE as a leaf qdisc with GSO
> splitting as it stands currently. I *think* the solution is for CAKE to
> notify its parents; could you try the patch below and see if it helps?
Aha, good news. :)
I’m probably not currently in a position to try it on my old kernels with the out of tree build:
On 3.16.7:
root@apu1a:~/src/sch_cake# make
make[1]: Entering directory '/usr/src/linux-headers-3.16.7-ckt9-voyage'
CC [M] /root/src/sch_cake/sch_cake.o
/root/src/sch_cake/sch_cake.c: In function ‘adjust_parent_qlen’:
/root/src/sch_cake/sch_cake.c:1738:20: error: ‘TCQ_F_NOPARENT’ undeclared (first use in this function)
if (sch->flags & TCQ_F_NOPARENT)
^
/root/src/sch_cake/sch_cake.c:1738:20: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:263: recipe for target '/root/src/sch_cake/sch_cake.o' failed
make[2]: *** [/root/src/sch_cake/sch_cake.o] Error 1
Makefile:1350: recipe for target '_module_/root/src/sch_cake' failed
make[1]: *** [_module_/root/src/sch_cake] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-3.16.7-ckt9-voyage'
Makefile:7: recipe for target 'default' failed
make: *** [default] Error 2
On 4.9.0-8:
root@apu2a:~/src/sch_cake$ make
make[1]: Entering directory '/usr/src/linux-headers-4.9.0-8-amd64'
CC [M] /home/sysadmin/src/sch_cake/sch_cake.o
Building modules, stage 2.
MODPOST 1 modules
WARNING: "qdisc_lookup" [/home/sysadmin/src/sch_cake/sch_cake.ko] undefined!
CC /home/sysadmin/src/sch_cake/sch_cake.mod.o
LD [M] /home/sysadmin/src/sch_cake/sch_cake.ko
make[1]: Leaving directory '/usr/src/linux-headers-4.9.0-8-amd64'
next prev parent reply other threads:[~2019-01-05 5:58 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 23:30 Pete Heist
2018-12-28 12:58 ` Pete Heist
2018-12-28 21:22 ` Pete Heist
2018-12-28 22:07 ` Jonathan Morton
2018-12-28 22:42 ` Pete Heist
2019-01-04 21:34 ` Toke Høiland-Jørgensen
2019-01-04 22:10 ` Pete Heist
2019-01-04 22:12 ` Pete Heist
2019-01-04 22:34 ` Toke Høiland-Jørgensen
2019-01-05 5:58 ` Pete Heist [this message]
2019-01-05 10:06 ` Toke Høiland-Jørgensen
2019-01-05 10:59 ` Pete Heist
2019-01-05 11:06 ` Pete Heist
2019-01-05 11:18 ` Toke Høiland-Jørgensen
2019-01-05 11:26 ` Pete Heist
2019-01-05 11:35 ` Pete Heist
2019-01-05 12:38 ` Toke Høiland-Jørgensen
2019-01-05 12:51 ` Pete Heist
2019-01-05 13:10 ` Toke Høiland-Jørgensen
2019-01-05 13:20 ` Pete Heist
2019-01-05 13:35 ` Toke Høiland-Jørgensen
2019-01-05 15:34 ` Pete Heist
2019-01-05 15:52 ` Jonathan Morton
2019-01-05 16:32 ` Toke Høiland-Jørgensen
2019-01-05 19:27 ` Sebastian Moeller
2019-01-05 20:01 ` Pete Heist
2019-01-05 20:10 ` Toke Høiland-Jørgensen
2019-01-05 20:31 ` Pete Heist
2019-01-05 22:27 ` Toke Høiland-Jørgensen
2019-01-05 22:41 ` Pete Heist
2019-01-06 9:37 ` Pete Heist
2019-01-06 20:56 ` Toke Høiland-Jørgensen
2019-01-07 0:30 ` Pete Heist
2019-01-07 2:11 ` Dave Taht
2019-01-07 11:30 ` Toke Høiland-Jørgensen
2019-01-07 15:07 ` Pete Heist
2019-01-08 20:03 ` Pete Heist
2019-01-08 20:44 ` Dave Taht
2019-01-08 22:01 ` Pete Heist
2019-01-08 22:33 ` Dave Taht
2019-01-09 6:13 ` Pete Heist
2019-01-08 22:27 ` Toke Høiland-Jørgensen
2019-01-09 5:29 ` Pete Heist
2019-01-09 8:36 ` Toke Høiland-Jørgensen
2019-01-06 20:55 ` Toke Høiland-Jørgensen
2019-01-05 10:44 ` Jonathan Morton
2019-01-05 11:17 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1F84884-7150-41BB-9E39-640F560F99D5@heistp.net \
--to=pete@heistp.net \
--cc=cake@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox