From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C32B73BA8E for ; Sat, 5 Jan 2019 00:58:06 -0500 (EST) Received: by mail-wm1-x32e.google.com with SMTP id f81so2998077wmd.4 for ; Fri, 04 Jan 2019 21:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=W0uKORj8hBpMbeINH3UOIsiLiIxm1//zFIEwc/cnA8E=; b=YjaHf8fA9T9SjbIoFaldBd3DRL4d6PwnMNRm6k83Hebl+o+0wN8c2KqiLvG3D8SUO0 HiZY3go7HJsBm5BpQIOP2O68TpQxo8JplZnLdyz8IKNFxm8dz67IY9KVW3huNsXELlfL 50EVOxPPl+T5jRjvd5Ej3PP/OHHcW9R++J66PEaUHcz7swg3KO6WSRb5Uh9MBly6vpYZ yIT9Pm42GNh/CavwdHzbdPVVOVMKleBqChqWTDRWMyQpuakZLKh+62Dz30/jADltvZ3k ebPRem1UXiE+bml1LcGjW247rO4Cor6hIXJMmRAVY5PQlCQ0rAsJjvQRy09JUEZdHV6k 3lcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=W0uKORj8hBpMbeINH3UOIsiLiIxm1//zFIEwc/cnA8E=; b=Lt58R0kuBJRg7k/UyevtjhMJ4KGYR3ILuLAfRWbNsKrLNHrx9Tq1uiQstIDEGk3qXl 6JcSOlDTHb/asICl0TOVS8Qg1AolqRlLUd46OY/JV0sQV2ChIGjZhO/XX/z8413rnVX1 kitGHGUsFwvlltqg2Gk18aJlro3UlGvRZC9NVzi0rMDCd9Rs8u1Pe7rLc7VeGsfd05kF K2ypYJFDDJ7WREFK5TyPwm6mqm/01xGb+N1AmO6ejRsKKYBI8eYZrQBFWjjjrpdFk0rQ Oop4HmSmbFxpgzF6jHxcIRjR0eIkC+4uiAiHUitJ2858hHE51TT66e8jz6WvtHWsDw8k CNWQ== X-Gm-Message-State: AJcUukfTpYGVnwREbCBbO+E3iEfVrApQpWAmS8nLtIShijsHhnnd2WYK SmX7hr1r0WgvBd5dWViIhvaEN+/Aa5M= X-Google-Smtp-Source: ALg8bN6XT7JjvsZzSQerW3ncocx7gq6+T4f5oYTvCKe0wkg5wB6Oy653ahVtUoDxjY+CBMetHwuZjA== X-Received: by 2002:a1c:6243:: with SMTP id w64mr3090765wmb.153.1546667885809; Fri, 04 Jan 2019 21:58:05 -0800 (PST) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id w18sm2016242wmi.12.2019.01.04.21.58.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jan 2019 21:58:05 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Pete Heist In-Reply-To: <87zhsgxdao.fsf@toke.dk> Date: Sat, 5 Jan 2019 06:58:03 +0100 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <5482A3CA-9C36-4DDE-A858-24D8467F70C7@heistp.net> <8736q8yumt.fsf@toke.dk> <4C422792-7E51-4DBA-A229-FA7D3F987FB6@heistp.net> <87zhsgxdao.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2019 05:58:07 -0000 > On Jan 4, 2019, at 11:34 PM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Pete Heist writes: >=20 > This basically means that we can't use CAKE as a leaf qdisc with GSO > splitting as it stands currently. I *think* the solution is for CAKE = to > notify its parents; could you try the patch below and see if it helps? Aha, good news. :) I=E2=80=99m probably not currently in a position to try it on my old = kernels with the out of tree build: On 3.16.7: root@apu1a:~/src/sch_cake# make make[1]: Entering directory '/usr/src/linux-headers-3.16.7-ckt9-voyage' CC [M] /root/src/sch_cake/sch_cake.o /root/src/sch_cake/sch_cake.c: In function =E2=80=98adjust_parent_qlen=E2=80= =99: /root/src/sch_cake/sch_cake.c:1738:20: error: =E2=80=98TCQ_F_NOPARENT=E2=80= =99 undeclared (first use in this function) if (sch->flags & TCQ_F_NOPARENT) ^ /root/src/sch_cake/sch_cake.c:1738:20: note: each undeclared identifier = is reported only once for each function it appears in scripts/Makefile.build:263: recipe for target = '/root/src/sch_cake/sch_cake.o' failed make[2]: *** [/root/src/sch_cake/sch_cake.o] Error 1 Makefile:1350: recipe for target '_module_/root/src/sch_cake' failed make[1]: *** [_module_/root/src/sch_cake] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-3.16.7-ckt9-voyage' Makefile:7: recipe for target 'default' failed make: *** [default] Error 2 On 4.9.0-8: root@apu2a:~/src/sch_cake$ make make[1]: Entering directory '/usr/src/linux-headers-4.9.0-8-amd64' CC [M] /home/sysadmin/src/sch_cake/sch_cake.o Building modules, stage 2. MODPOST 1 modules WARNING: "qdisc_lookup" [/home/sysadmin/src/sch_cake/sch_cake.ko] = undefined! CC /home/sysadmin/src/sch_cake/sch_cake.mod.o LD [M] /home/sysadmin/src/sch_cake/sch_cake.ko make[1]: Leaving directory '/usr/src/linux-headers-4.9.0-8-amd64'