From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Georgios Amanakis <gamanakis@gmail.com>
Cc: "Cake@lists.bufferbloat.net" <Cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake in lede-17.01
Date: Sun, 15 Jul 2018 16:43:36 +0000 [thread overview]
Message-ID: <B4498E4F-9CC7-4852-86EE-77148DD678F8@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CACvFP_hU_vQqq6eqj5AMp=2gr62ozihu+5UwVP8-OUD0xZa+ig@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
> On 15 Jul 2018, at 17:13, Georgios Amanakis <gamanakis@gmail.com> wrote:
>
> I am not sure we need this in 4.4.
> In the patch we check for "d->tail->nla_type == padattr".
> However, all gnet_stats_copy*() are defined without a padding attribute.
Hmm, I wonder how they handle attribute alignment on MIPS….or maybe just don’t care.
>
> On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine.
Which would suggest “it just works”. Try adding/removing some extra config options.
>
> Any insight would be greatly appreciated.
>
> George
>
Cheers,
Kevin D-B
012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-07-15 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 13:32 Georgios Amanakis
2018-07-15 14:43 ` Kevin Darbyshire-Bryant
2018-07-15 16:13 ` Georgios Amanakis
2018-07-15 16:43 ` Kevin Darbyshire-Bryant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B4498E4F-9CC7-4852-86EE-77148DD678F8@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=Cake@lists.bufferbloat.net \
--cc=gamanakis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox