[Cake] cake in lede-17.01

[Cake] cake in lede-17.01

[Georgios Amanakis]

Dear All,

I backported cake as of commit c91b94f and tc-adv as of 3968731
(latest). I tested in a TP-Link WR-941NDv3 and everything looks ok,
including the stats.

Could someone take a look at the pull requests?
https://github.com/openwrt/openwrt/pull/1180
https://github.com/openwrt/openwrt/pull/1179

Thank you,
George

Re: [Cake] cake in lede-17.01

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]



> On 15 Jul 2018, at 14:32, Georgios Amanakis <gamanakis@gmail.com> wrote:
> 
> Dear All,
> 
> I backported cake as of commit c91b94f and tc-adv as of 3968731
> (latest). I tested in a TP-Link WR-941NDv3 and everything looks ok,
> including the stats.
> 
> Could someone take a look at the pull requests?
> https://github.com/openwrt/openwrt/pull/1180
> https://github.com/openwrt/openwrt/pull/1179

I think would also need https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=3e81365141e4626522c616e7870d246594eff26d

backported to 4.4 as well.

> 
> Thank you,
> George
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake


Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [Cake] cake in lede-17.01

[Georgios Amanakis]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

I am not sure we need this in 4.4.
In the patch we check for "d->tail->nla_type == padattr".
However, all gnet_stats_copy*() are defined without a padding attribute.

On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine.

Any insight would be greatly appreciated.

George

[-- Attachment #2: Type: text/html, Size: 547 bytes --]

Re: [Cake] cake in lede-17.01

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]



> On 15 Jul 2018, at 17:13, Georgios Amanakis <gamanakis@gmail.com> wrote:
> 
> I am not sure we need this in 4.4.
> In the patch we check for "d->tail->nla_type == padattr".
> However, all gnet_stats_copy*() are defined without a padding attribute.

Hmm, I wonder how they handle attribute alignment on MIPS….or maybe just don’t care.

> 
> On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine.

Which would suggest “it just works”.  Try adding/removing some extra config options.

> 
> Any insight would be greatly appreciated.
> 
> George
> 


Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]