From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 7A60721F768 for ; Mon, 5 Oct 2015 00:28:04 -0700 (PDT) Received: from u-089-d060.biologie.uni-tuebingen.de ([134.2.89.60]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LcBin-1aSTQa37J7-00jXnn; Mon, 05 Oct 2015 09:28:01 +0200 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: <56116611.8050907@darbyshire-bryant.me.uk> Date: Mon, 5 Oct 2015 09:27:58 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <56102F88.8070201@darbyshire-bryant.me.uk> <94F988FA-894E-4F04-B5BC-4BF6539D0730@gmx.de> <56116611.8050907@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:PPF5AEAec9Gt9gLMdgVgDkm78eiympyv7CQ/x+Wc4902j+hAvgT N45Vmt+pW+da/wVJaoF3NRoXzFNpLjFhj2F53DkQVZsCd3Jy7pDGJdwIu95q9cG9fP1yyri gSenUVS8QgXQ73V4ONeyVdtuKtvHVzbq9oiDcgg8O+ty86lbnF60XGfFMnxzrjTdF8XuOu5 ksjhTPj02vIKpsZnCx1IQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:aA8XK2Kl5QU=:0RR6KpI/6YJnPVyEluEnCT wraXrXoKK2Ibw3Bze1e7vm7KRstbjLuz0RayKx1EFdwIg6uFwCckvjs7C+vxnjJWqMqbMYqWf uqNOD28I2U3eZMlFZyNvrC5idOniPEqMXGNPfNGNYBx+AwwSMGU8kL/zSinaidAVYArrLg4BU 88K0vcrH0kAZXpMZbrlK2GNy9iaenKbv3q8lkKc6OB6f/F/MJFY1TB2oeacZQLIomYBeWZMnw EkpXWYqMQzNHp0DDgZtt2CE/Ltbxu6R97DrqIBW5Zt5mV82ntX3MSJmjPw+G0ze4Ue8DNfSC3 D8vdW6fZC+LJD4uE+sVWROUfkvGgMcRD4NloXeeLOOmZukEOxUrXCgqOlTRfB4jyxXY+S0VMx McKWTLiNx9NC1iRzIOkfVq4QZtbkGbEL9e8jxo65sP7QpDygfORSQBJN73oaReG5HtyVfNAqk s0LxIo/l+SNN8d+739Yu0uOMvQ0uEtvOuXO8ntHaHwvEAKMKCMZD7vpk8mFl7uAk/2PRmWZ7b xmxcZXXVCq1L9lw3tdYxLokIZAMTCz2FnL7DOzkWQ6HExkfAjfdfe7AUat9p4Zm4gonXSshL1 f3mRCKRGZTiYxoe8m23II0WNEFuRGHXoHawzJj1icDt+Yn4A0qvezqsPxQzi1Yp3OP6SDOpCJ /L0+ZtXcuxPQn9mMx4d1q5uIDwjvQxd2Ak1MFAOX+DYd/iwZvN+cqfnbKIBbULIYsbTZSmNqR Wy1G1uhpycrmuGcWNniG0XXUPmc8HqNP7+Y+3ijM6WZVz1mAbMmWYalk44QAjPVDtf+bgEnvR Y8czkH6 Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] cake review comments cake_drop X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 07:28:28 -0000 Hi Kevin, On Oct 4, 2015, at 19:46 , Kevin Darbyshire-Bryant = wrote: > On 04/10/15 11:56, Sebastian Moeller wrote: >> Hi Jonathan, hi Kevin, >>=20 >>=20 >> On Oct 4, 2015, at 11:03 , Jonathan Morton = wrote: >>=20 >>> I remember changing cake_drop so that it iterated over the list of = active flows rather than the whole potential array. Hence an inactive = class, which has no active queues, costs nothing to iterate over. = Usually the total number of active queues is tolerably small. >> Ah, so there is the answer to my question ;) Jonathan, which of = the public repositories is the closest to your internal version, so = which is the semi-official one? > It is exists in Dave's repo. It iterates over the 'old_flows' and > 'new_flows' lists for each class looking for the one in most = 'distress', > inherently if there's active data to be found it should be on one of > those lists. Ah, that is what list_for_each_entry() does=85 Thanks for = spelling it out for me=85 Best Regards sebastian >=20 > In cpu cycle pedant mode, checking for a null list on a set of classes > we know are going to be empty is unnecessary, in a single class config > that's 7 (actually 14) null list searches we don't have to do. I'm = sure > it's not much of a saving but every cycle helps. >=20 >=20